Skip to content

FastNoise2: Add simd support for Android#754

Open
beicause wants to merge 1 commit intoZylann:masterfrom
beicause:fastnoise2-simd-android
Open

FastNoise2: Add simd support for Android#754
beicause wants to merge 1 commit intoZylann:masterfrom
beicause:fastnoise2-simd-android

Conversation

@beicause
Copy link
Contributor

Tested on arm64 Android phone, Neon works.
Not yet test arm32, but I guess it should also work.

@beicause beicause force-pushed the fastnoise2-simd-android branch 4 times, most recently from 1967257 to 97994f6 Compare April 22, 2025 18:03
@beicause beicause force-pushed the fastnoise2-simd-android branch from 97994f6 to 56e4cf1 Compare April 23, 2025 04:36
@beicause
Copy link
Contributor Author

There is still a issue that SSE is also compiled on arm unnecessarily. Meanwhile, I didn't consider X86 Android. I will fix these later.

env_fn2_sse2.add_source_files(env.modules_sources, fn2_sources_sse2)
env_fn2_sse3.add_source_files(env.modules_sources, fn2_sources_sse3)
env_fn2_ssse3.add_source_files(env.modules_sources, fn2_sources_ssse3)
env_fn2_sse41.add_source_files(env.modules_sources, fn2_sources_sse41)
env_fn2_sse42.add_source_files(env.modules_sources, fn2_sources_sse42)

@beicause
Copy link
Contributor Author

I think we should compile FastNoise2 on all platforms by default. At least the scalar level is always available.

@beicause beicause force-pushed the fastnoise2-simd-android branch from 56e4cf1 to 8eadc3d Compare April 23, 2025 10:21
@beicause beicause force-pushed the fastnoise2-simd-android branch from 8eadc3d to ee7fd33 Compare April 23, 2025 10:24
@beicause
Copy link
Contributor Author

beicause commented Apr 23, 2025

I don't have an iOS device,
but I created a branch to test iOS in the CI, and it also compiled successfully. https://github.com/beicause/godot_voxel/actions/runs/14616030217/job/41004367330 (It wrongly builds macos template 😅.)

Edit: correct iOS CI https://github.com/beicause/godot_voxel/actions/runs/14616201444/job/41004911388

So NEON might work in arm macOS and iOS ?

@Zylann
Copy link
Owner

Zylann commented Apr 26, 2025

Needs to be tested, I don't have a Mac to confirm that.

@NuclearPhoenixx
Copy link
Contributor

FastNoise2 version 1.0 has just been released with updates to SIMD, so an upgrade to the new release might be something to look at as well.

https://github.com/Auburn/FastNoise2/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants