feat: message search within conversation#622
Open
sakebomb wants to merge 1 commit intoa-ghorbani:mainfrom
Open
feat: message search within conversation#622sakebomb wants to merge 1 commit intoa-ghorbani:mainfrom
sakebomb wants to merge 1 commit intoa-ghorbani:mainfrom
Conversation
Add search functionality to find messages within the active chat session: - Search bar appears via toolbar icon with auto-focus input - Filters messages in real-time as user types (case-insensitive) - Highlights matching text in message content using <mark> tags - Shows match count or "No results" indicator - Uses SearchQueryContext to pass search state to MarkdownView without prop drilling through the component tree - Registers custom mark HTML element model for react-native-render-html - Adds search l10n strings (searchMessages, noResults) - Includes 15 new tests covering store, component, and integration Closes a-ghorbani#603
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<mark>tags viaSearchQueryContext(avoids prop drilling through ChatView → Message → TextMessage → MarkdownView chain)Implementation details
isSearchMode,searchQuery,enterSearchMode(),exitSearchMode(),setSearchQuery(),filteredSessionMessagesgetter (case-insensitive text filtering)customContentprop; wraps ChatView inSearchQueryContext.ProviderSearchQueryContext, wraps matching text in<mark>tags after markdown-to-HTML conversion, registersmarkelement model withreact-native-render-htmlchat.searchMessages,chat.noResultsstrings added to en.jsonTest plan
Closes #603