Skip to content

Fix some eslint problems#198

Draft
fraknoiadam wants to merge 10 commits intomainfrom
feature/181-fix-eslint
Draft

Fix some eslint problems#198
fraknoiadam wants to merge 10 commits intomainfrom
feature/181-fix-eslint

Conversation

@fraknoiadam
Copy link
Copy Markdown
Member

@fraknoiadam fraknoiadam commented Jan 26, 2026

Issue: #181

@OregSamSas
Copy link
Copy Markdown
Contributor

Sorry for meddling in, it seemed a relatively monotone and tedious, but also easy task for me (i.e. "good first issue"/"good for newcomers" 😄).

I disabled marking empty functions and interfaces as an error? What about static classes, and non-null assertions? Do we allow those, or not?

Ádám Fraknói and others added 2 commits February 14, 2026 17:54
…g, async where is a promise required, relay subbmitAnswer() gets a number, now it's ensured + empty function and inerface warnings shouldn't be serious errors, right?
@OregSamSas OregSamSas force-pushed the feature/181-fix-eslint branch from 9109c54 to 5e2d6be Compare February 14, 2026 17:00
@OregSamSas
Copy link
Copy Markdown
Contributor

I rebased the branch and solved merging conflicts. (In the version-specific-colours update, some lines were modified with ES-Lint errors (lines containing String instead of strin), and the lazy-loading-smg-or-whatever-was-its-name by David used types instead of interfaces added in Adam's e16db04 commit, which I also readded on updating the branch to those modifications too.)

… is not reassigned in scope, remopve unneccessary es-lint ignorations, type issues, imports), and type error with relay input
…uldn't have a transparent background I think
@OregSamSas OregSamSas self-assigned this Mar 7, 2026
…logs shouldn't have a transparent background I think"

(Since unrelated, movedd to a new branch and to different PR.)

This reverts commit 2c3e1d8.
…idea why needed ever: the && operator short-circuits before evaluating right operation (<TeamDetailDialog>) if variable on left is null
@OregSamSas
Copy link
Copy Markdown
Contributor

Don't we need the eslint-plugin-react-hooks package?
I see multiple rows ignoring rules from there.

@OregSamSas
Copy link
Copy Markdown
Contributor

Also, what is src/lobby.tsx? it's got loads of errors (missing modules to import)

…d in these files, I think checking whether objects are non-null would complicate code more then just asserting they aren't)
…handling them being null would overcomplicate code there)
@OregSamSas
Copy link
Copy Markdown
Contributor

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants