Internationalisation by OregSamSas · Pull Request #207 · a-gondolkodas-orome/durer-aion

OregSamSas · 2026-03-26T23:53:56Z

Default view

Mobile view

Tasks

a-gondolkodas-orome/durer-infra/issues/44 : Translation Resources in Config file
adding a method to switch between languages
- TODO: customise available languages from env file or the i18n config file rather than in the Langswitcher file ✅
- TODO: remove language selector for the time being
Replace all frontend strings with loaded content from i18n config #208
- TODO: clear namespace issues, use better syntax everywhere ✅
- TODO: use and in strings instead of , use relay.error

Handling the possibility of loading strategy game description and relay tasks in another language #209

Fix building (CLI) issues (package problems)

test on Offline and Online frontend ✅

localise admin interface?

Copilot

Pull request overview

Introduces i18next/react-i18next-based internationalisation into the shared common-frontend package and starts migrating the Disclaimer UI to use translated strings.

Changes:

Add i18next + browser language detection + react-i18next dependencies and an i18n initialization module with embedded EN/HU resources.
Update Disclaimer to use t() / <Trans /> for some disclaimer strings.
Adjust tsup config to avoid bundling node_modules dependencies.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
packages/common-frontend/tsup.config.ts	Configures tsup to keep node_modules deps external (imported) during bundling.
packages/common-frontend/src/common/i18n.ts	Adds i18next initialization and embedded EN/HU translation resources.
packages/common-frontend/src/client/components/Disclaimer.tsx	Migrates parts of the Disclaimer UI from `dictionary` to i18next translations.
packages/common-frontend/package.json	Adds i18next/react-i18next dependencies to the common frontend package.
package.json	Adds i18next/react-i18next dependencies at the repo root.
package-lock.json	Locks new i18n dependencies and their transitive deps.
apps/offline-frontend/src/App.tsx	Imports the i18n init module as a side-effect.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/common-frontend/src/common/i18n.ts

packages/common-frontend/src/client/components/Disclaimer.tsx

apps/offline-frontend/src/App.tsx

packages/common-frontend/src/common/i18n.ts

OregSamSas · 2026-03-28T12:38:14Z

@fraknoiadam Huge-huge sorry! I forgot to make this PR to a draft 😢 😳 I just wanted to make it available to follow my progress, but I'm far from doing anything mergable...

…project's whole scope, finish localising Disclaimer and Header (added a language switcher as well)

… names, improve mobile language selector, rework colour endrelaytable a bit

…through the i18n object + use empty error translation for no login code

… go back to TS v4.7.4)

…slation through the i18n object + use empty error translation for no login code" This reverts commit d6e8688.

…ge.json, go back to TS v4.7.4)" This reverts commit 96ef07b.

This reverts commit c6e2e60.

OregSamSas · 2026-03-28T22:35:48Z

Oh, it seems I messedc up with something, and reverting them won't work even 😭

fraknoiadam

It is a very good PR. This is a very hard task, but you managing it very well. I added some comments. Didn't check every file yet, especially not the language selector.

In online round we may don't want to enable multiple languages, only allow Hungarian. I don't know yet how that one could be resolved. Maybe it is better if the language selector is a different PR, and now hard code it to use Hungarian language. But this is just an idea, not a preference from my side.

package.json

packages/common-frontend/src/common/boardwrapper.tsx

packages/common-frontend/src/client/components/Disclaimer.tsx

…rome/durer-aion into feature/186-i18n

fraknoiadam

I don't know whether you were waiting for reviews, but I had some time, so I made short review.

Also, please don't close the discussions. I will check whether they are implemented and close them.

apps/offline-frontend/src/client-repository.ts

packages/common-frontend/src/common/i18n.ts

packages/common-frontend/src/common/boardwrapper.tsx

fraknoiadam · 2026-04-03T20:56:06Z

packages/common-frontend/src/common/boardwrapper.tsx

            {description}
-            <strong>Tudnivalók: </strong>Az "Új próbajáték kezdése" gombra kattintva próbajáték indul, ami a pontozásba nem számít bele. Bátran kérjetek próbajátékot, hiszen ezzel tudjátok tesztelni, hogy jól értitek-e a játék működését. Az "Új éles játék kezdése" gombra kattintva indul a valódi játék, ami már pontért megy.
-
+            <strong>{t('strategy:instructions')}</strong>{t('strategy:instructionDescription')}


This one can be also in one t function. You can use formatting instead in the i18n.

Actually, I disagree, since these two strings are separated visually enough, and also, the header string might be reused somewhere else (I might even wrap the header into a different element)

packages/common-frontend/src/common/boardwrapper.tsx

fraknoiadam · 2026-04-03T21:00:34Z

packages/common-frontend/src/client/components/ExcerciseForm.tsx

-            .min(0, 'A válasz 0 és 9999 között van')
-            .max(9999, 'A válasz 0 és 9999 között van')
-            .required('Nem írtál semmi választ!')
+            .integer(t('error:integer'))


I would write relay.error.integer

I see your point from one point of view. But on the other hand, I think it shouldn't be relay specific. And I'd collect all errors under error.* since I think we should group messages in a way to have larger groups.

packages/common-frontend/src/client/components/ExcerciseForm.tsx

packages/common-frontend/src/client/components/Disclaimer.tsx

…x and one namespace in translation resources, remove redundant dependencies from root level package.json, define TS version for VS Code, add missing translation and rework string grouping, refrain from using dangerouslySetInnerHTML with <Trans />

…oad directly into JS from it, packaga.json was only reordered)

OregSamSas · 2026-04-05T23:34:28Z

Also, please don't close the discussions. I will check whether they are implemented and close them.

Oh, sorry, didn't read your message through carefully enough. I resolve comments, if I implemented them in order to be free from them in VS Code editor, they're using a lot of space -- still if I've dealt with them already. But I'll stop doing this practice then of course. 🙇

OregSamSas · 2026-04-05T23:45:56Z

Sadly, it doesn't seem to work on the online version yet...

~~IDK why though, since translations are not app-related, they're in common-frontend~~
Update: I missed an npm run build, it seems

fraknoiadam · 2026-04-06T16:50:06Z

apps/offline-frontend/src/client-repository.ts

  const teamstateString = localStorage.getItem(LOCAL_STORAGE_TEAMSTATE);
  if (teamstateString === null) {
-    throw new Error('Váratlan hiba történt');
+    throw new Error(i18n.t('unexpected'));


Suggested change

throw new Error(i18n.t('unexpected'));

throw new Error(i18n.t('error.unexpected'));

OregSamSas added 2 commits March 26, 2026 20:10

install react-i18next

b258788

realising and testing i18n functions on the disclaimer page

49af0df

fraknoiadam requested a review from Copilot March 28, 2026 07:06

Copilot started reviewing on behalf of fraknoiadam March 28, 2026 07:06 View session

Copilot AI reviewed Mar 28, 2026

View reviewed changes

OregSamSas marked this pull request as draft March 28, 2026 12:48

OregSamSas self-assigned this Mar 28, 2026

delete iuinnecessary input, but export our i18n config file into the …

da75fb4

…project's whole scope, finish localising Disclaimer and Header (added a language switcher as well)

a-gondolkodas-orome deleted a comment from Copilot AI Mar 28, 2026

OregSamSas added 8 commits March 28, 2026 18:12

solve small typing issues

08b93b7

localise Strategy page and other strings already using the dictionary

095d8f4

styles and translation corrections

e91bf04

fix bug

42acf5b

solve wrong colour for language switcher dropdown, translate language…

4aa354f

… names, improve mobile language selector, rework colour endrelaytable a bit

small language correction

8ad6c14

translating login errors

8992085

hooks cannot be called from here, so use direct acces of translation …

d6e8688

…through the i18n object + use empty error translation for no login code

OregSamSas marked this pull request as ready for review March 28, 2026 21:51

OregSamSas added 5 commits March 28, 2026 23:01

address CLI errors (remove unnecessary i18n in the root package.json,…

96ef07b

… go back to TS v4.7.4)

sync package-lock.json with package.json

c6e2e60

Revert "hooks cannot be called from here, so use direct acces of tran…

c23c9ef

…slation through the i18n object + use empty error translation for no login code" This reverts commit d6e8688.

Revert "address CLI errors (remove unnecessary i18n in the root packa…

eb0c2f1

…ge.json, go back to TS v4.7.4)" This reverts commit 96ef07b.

Revert "sync package-lock.json with package.json"

f73a211

This reverts commit c6e2e60.

OregSamSas marked this pull request as draft March 28, 2026 22:35

fraknoiadam reviewed Mar 29, 2026

View reviewed changes

OregSamSas added 3 commits March 30, 2026 00:34

use namespaces when defining t, use better <Trans /> syntax

d9bf0ef

Merge branch 'feature/186-i18n' of https://github.com/a-gondolkodas-o…

91b3d04

…rome/durer-aion into feature/186-i18n

use camel case

e76f1ef

fraknoiadam reviewed Apr 3, 2026

View reviewed changes

OregSamSas added 3 commits April 6, 2026 00:14

upgrade to TS v5 since react-i18next requires it

bf93ceb

separate translations into different JSON files (update tsconfig to l…

a655c1c

…oad directly into JS from it, packaga.json was only reordered)

OregSamSas marked this pull request as ready for review April 5, 2026 23:28

fraknoiadam reviewed Apr 6, 2026

View reviewed changes

	throw new Error(i18n.t('unexpected'));
	throw new Error(i18n.t('error.unexpected'));

Conversation

OregSamSas commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Default view

Mobile view

Tasks

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OregSamSas commented Mar 28, 2026

Uh oh!

OregSamSas commented Mar 28, 2026

Uh oh!

fraknoiadam left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fraknoiadam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fraknoiadam Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

OregSamSas Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fraknoiadam Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

OregSamSas Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OregSamSas commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OregSamSas commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fraknoiadam Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OregSamSas commented Mar 26, 2026 •

edited

Loading

fraknoiadam left a comment •

edited

Loading

OregSamSas commented Apr 5, 2026 •

edited

Loading

OregSamSas commented Apr 5, 2026 •

edited

Loading