-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docs: Added adr template and protojson adr #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @darrelmiller, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an ADR template and a specific ADR (ADR-001) that documents the decision to use ProtoJSON for JSON serialization in the A2A specification. This aims to standardize JSON serialization and improve interoperability, but it also acknowledges potential breaking changes and migration efforts for existing implementations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an Architecture Decision Record (ADR) for using ProtoJSON as the standard for JSON serialization, along with a template for future ADRs. The changes are well-structured and clearly articulate the decision-making process. My feedback includes a few minor corrections for typos and grammar in the ADR, and a suggestion to improve consistency between the new ADR and the template.
…rotoJSON serialization
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/vote |
Vote created@darrelmiller has called for a vote on The members of the following teams have binding votes:
Non-binding votes are also appreciated as a sign of support! How to voteYou can cast your vote by reacting to
Please note that voting for multiple options is not allowed and those votes won't be counted. The vote will be open for |
Vote statusSo far Summary
Binding votes (3)
|
3 similar comments
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
1 similar comment
Vote statusSo far Summary
Binding votes (3)
|
Vote closedThe vote did not pass.
Summary
Binding votes (4)
|
|
This vote actually passed, editing labels to be clear. |
Added ADR that captures decision to use ProtoJSON as the normative reference for JSON serialization