Skip to content

Conversation

@herczyn
Copy link
Member

@herczyn herczyn commented Dec 5, 2025

Fixes #1276.

@herczyn herczyn requested a review from a team as a code owner December 5, 2025 08:53
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @herczyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the A2A gRPC service specification by introducing new functionalities to pause and resume tasks. It defines new RPC methods, corresponding request messages, and updates the TaskState enum and AgentCapabilities to support these operations, providing more granular control over task execution within the A2A system.

Highlights

  • New Task Control Methods: Introduced PauseTask and ResumeTask RPC methods to the A2AService, allowing for the suspension and continuation of tasks. These methods include RESTful HTTP bindings for flexible API access.
  • Task State Update: Added TASK_STATE_PAUSED to the TaskState enum to represent tasks that are in a paused state. Note: This new enum value 8 duplicates an existing value (TASK_STATE_AUTH_REQUIRED), which is an error in Protocol Buffers and should be corrected.
  • Agent Capability Declaration: A new pause_resume boolean field was added to AgentCapabilities to indicate whether an agent supports the ability to pause and resume tasks.
  • New Request Messages: Defined PauseTaskRequest and ResumeTaskRequest messages, which specify the necessary parameters (tenant and task name) for initiating pause and resume operations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces PauseTask and ResumeTask methods to the A2A service, along with the necessary supporting changes in the protobuf specification. The implementation is mostly correct, but there is a critical issue with a duplicate enum value in TaskState that must be addressed. Additionally, there are some minor copy-paste errors in the comments for the new request messages that should be corrected for clarity.

herczyn and others added 2 commits December 5, 2025 13:59
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@herczyn herczyn enabled auto-merge (squash) December 5, 2025 14:13
@holtskinner holtskinner added the TSC Review To be reviewed by the Technical Steering Committee label Dec 9, 2025
@github-project-automation github-project-automation bot moved this to Backlog in TSC Review Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TSC Review To be reviewed by the Technical Steering Committee

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

[Feat]: Add PauseTask and Resume task to A2A service.

2 participants