-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(spec): add file_with_text field to FilePart for text-based formats #1298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matous Havlena <havlenma@gmail.com>
Summary of ChangesHello @matoushavlena, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a file_with_text field to FilePart to enable sending text-based file formats more efficiently by avoiding unnecessary base64 encoding. The changes are consistently applied across the protocol definition and documentation, and the feature is fully backward compatible. My review includes one minor suggestion to clarify in the protocol definition that the content for file_with_text must be a valid UTF-8 string, as this is a requirement for protobuf string types and is important for implementers to know. Overall, this is a well-implemented and useful feature.
| // The base64-encoded content of the file. | ||
| // The base64-encoded content of the file (for binary data). | ||
| bytes file_with_bytes = 2; | ||
| // The plain text content of the file (for text-based file formats). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since protobuf string types must be valid UTF-8, it's important to clarify this constraint for implementers. For text files with encodings other than UTF-8, file_with_bytes should be used. Please consider adding a note about the UTF-8 requirement.
| // The plain text content of the file (for text-based file formats). | |
| // The plain text content of the file (for text-based file formats). The content MUST be valid UTF-8. |
|
/vote |
Vote created@geneknit has called for a vote on The members of the following teams have binding votes:
Non-binding votes are also appreciated as a sign of support! How to voteYou can cast your vote by reacting to
Please note that voting for multiple options is not allowed and those votes won't be counted. The vote will be open for |
Vote statusSo far Summary
Binding votes (2)
|
5 similar comments
Vote statusSo far Summary
Binding votes (2)
|
Vote statusSo far Summary
Binding votes (2)
|
Vote statusSo far Summary
Binding votes (2)
|
Vote statusSo far Summary
Binding votes (2)
|
Vote statusSo far Summary
Binding votes (2)
|
Vote statusSo far Summary
Binding votes (3)
|
8 similar comments
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
17 similar comments
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
Vote statusSo far Summary
Binding votes (3)
|
|
Closing this as there is a new proposal that addresses this requirement in #1255 |
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
|
/cancel-vote Moving to #1255 to keep this clean |
Vote cancelled@amye has cancelled the vote in progress in this pull request. |
Adds
file_with_textfield toFilePartto enable sending text-based file formats without unnecessary base64 encoding.Fully backward compatible. Existing
file_with_bytesandfile_with_uricontinue to work unchanged.Resolves #1255