-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(spec)!: modernize oauth 2.0 flows - remove implicit/password, add device code / pkce #1303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @msardara, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly modernizes the OAuth 2.0 flow support by deprecating and removing less secure flows, specifically the Implicit and Password grants, in favor of more robust alternatives. It introduces the Device Code flow for specialized client types and enhances the security of the Authorization Code flow by adding explicit support for PKCE, aligning the specification with current OAuth 2.0 security best practices. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request modernizes the OAuth 2.0 flow support by removing deprecated implicit and password flows, and adding the more secure Device Code flow and PKCE requirement for the Authorization Code flow. The changes are well-implemented across both the protobuf specification and the documentation. My only suggestion is to explicitly mark the removed field tags as reserved in the protobuf definition for better long-term maintainability. Overall, this is an excellent security and modernization improvement.
|
/vote |
Vote created@amye has called for a vote on The members of the following teams have binding votes:
Non-binding votes are also appreciated as a sign of support! How to voteYou can cast your vote by reacting to
Please note that voting for multiple options is not allowed and those votes won't be counted. The vote will be open for |
Vote statusSo far Summary
Binding votes (1)
|
3 similar comments
Vote statusSo far Summary
Binding votes (1)
|
Vote statusSo far Summary
Binding votes (1)
|
Vote statusSo far Summary
Binding votes (1)
|
Vote statusSo far Summary
Binding votes (2)
|
2 similar comments
Vote statusSo far Summary
Binding votes (2)
|
Vote statusSo far Summary
Binding votes (2)
|
Vote statusSo far Summary
Binding votes (4)
|
9 similar comments
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
6 similar comments
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
… device code / pkce
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
5 similar comments
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote statusSo far Summary
Binding votes (4)
|
Vote closedThe vote passed! 🎉
Summary
Binding votes (5)
|
Description
Modernizes OAuth 2.0 flow support by removing deprecated
flows and adding modern, secure alternatives.
Fixes: #1234
Changes
Breaking Changes
Removed (deprecated by OAuth 2.0 Security BCP):
ImplicitOAuthFlow- Use Authorization Code + PKCE insteadPasswordOAuthFlow- Use Authorization Code + PKCE or Device Code insteadAdded
New OAuth Flow:
DeviceCodeOAuthFlow(RFC 8628) - For CLI tools, IoT devices, and input-constrained scenariosEnhanced Security:
pkce_requiredfield added toAuthorizationCodeOAuthFlow(RFC 7636)