feat: Add strong naming assemblies signing#157
Merged
Blackhex merged 2 commits intoa2aproject:mainfrom Aug 29, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements strong naming for assemblies by enabling assembly signing across the project. It migrates from using AssemblyInfo.cs files to MSBuild project file configurations for managing InternalsVisibleTo attributes with public keys.
- Enables strong naming by configuring SignAssembly and AssemblyOriginatorKeyFile properties
- Migrates InternalsVisibleTo declarations from AssemblyInfo.cs files to MSBuild project files
- Adds public keys to InternalsVisibleTo entries to support signed assemblies
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Enables assembly signing for all projects with shared key file configuration |
| src/A2A/Properties/AssemblyInfo.cs | Removes InternalsVisibleTo attributes (migrated to project file) |
| src/A2A/A2A.csproj | Adds InternalsVisibleTo entries with public keys for test assemblies |
| src/A2A.AspNetCore/properties/AssemblyInfo.cs | Removes InternalsVisibleTo attributes (migrated to project file) |
| src/A2A.AspNetCore/A2A.AspNetCore.csproj | Adds InternalsVisibleTo entry with public key for test assembly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
darrelmiller
approved these changes
Aug 28, 2025
rokonec
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InternalsVisibleToin*.csproj.AssemblyInfo.csfiles,InternalsVisibleTonow handled by*.csproj.Motivation
Linked Issues