Skip to content

Comments

feat: Remove custom JSON converters for enums#32

Merged
stephentoub merged 2 commits intoa2aproject:mainfrom
stephentoub:enumconverter
Jul 8, 2025
Merged

feat: Remove custom JSON converters for enums#32
stephentoub merged 2 commits intoa2aproject:mainfrom
stephentoub:enumconverter

Conversation

@stephentoub
Copy link
Collaborator

No description provided.

@stephentoub stephentoub enabled auto-merge July 7, 2025 13:59
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @stephentoub, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to streamline and standardize how enums are serialized to JSON. By replacing custom, enum-specific converters with a single, reusable generic converter that handles kebab-case lower serialization, I've reduced code duplication and improved the maintainability of the serialization logic across the application.

Highlights

  • Serialization Refactor: I've refactored the JSON serialization for enums by replacing custom, hand-written JsonConverter implementations with a standardized, generic approach.
  • Code Reduction: This change eliminates boilerplate code by removing specific JsonConverter classes, such as MessageRoleConverter, which were previously responsible for handling enum serialization.
  • New Utility Converter: I've introduced a new generic JsonConverter, KebabCaseLowerJsonStringEnumConverter<TEnum>, which leverages System.Text.Json's built-in capabilities to serialize enum values into kebab-case lower strings. This converter is now applied to MessageRole and TaskState enums.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the JSON serialization of enums by replacing custom converters with a new generic KebabCaseLowerJsonStringEnumConverter. My review has identified a potential critical breaking change in the JSON format for enums with multi-word names (e.g., TaskState.InputRequired), and a high severity compatibility issue with using C# 12 primary constructors in the new converter, as the library targets netstandard2.0, which does not officially support this feature.

@stephentoub stephentoub added this pull request to the merge queue Jul 8, 2025
Merged via the queue into a2aproject:main with commit 2cc12d2 Jul 8, 2025
4 checks passed
@stephentoub stephentoub deleted the enumconverter branch July 8, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants