Skip to content

Comments

fix: fix sse deserialization#35

Merged
SergeyMenshykh merged 4 commits intoa2aproject:mainfrom
SergeyMenshykh:fix-sse-deserialization
Jul 8, 2025
Merged

fix: fix sse deserialization#35
SergeyMenshykh merged 4 commits intoa2aproject:mainfrom
SergeyMenshykh:fix-sse-deserialization

Conversation

@SergeyMenshykh
Copy link
Collaborator

This PR fixes the deserialization of SSE events by polymorphically deserializing the event data from the result property (see the JSON example below) instead of the event(entire JSON object) itself:

{  
    "id": "4e5f4e5a-9b2c-485b-b6dc-4ddbeb1988d1",  
    "jsonrpc": "2.0",  
    "result": {  
        "kind": "message",  
        "messageId": "36818e79-700c-4795-a2e5-bf7f48f38fb3",  
        "parts": [  
            {  
                "kind": "text",  
                "text": "Hello World"  
            }  
        ],  
        "role": "agent"  
    }  
}  

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @SergeyMenshykh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the deserialization of Server-Sent Events (SSE) by ensuring that the client correctly parses the event data from the result field of a JSON-RPC response. This change is crucial for the client to properly interpret and process incoming SSE messages, and it is supported by corresponding updates to the client sample application and unit tests to validate the new deserialization logic.

Highlights

  • SSE Deserialization Fix: Modified the A2AClient to correctly deserialize Server-Sent Events (SSE) by extracting the event data from the result property of a JSON-RPC response, rather than attempting to deserialize the entire JSON object. This aligns with the expected JSON-RPC envelope for SSE data.
  • Client Sample Update: Enhanced the Program.cs sample client to include MessageId and ContextId when sending messages, and added specific handling for Message type events received via SSE, including printing message details and text parts.
  • Unit Test Adjustments: Updated several unit tests in A2AClientTests.cs to reflect the new JSON-RPC response structure for SSE events, ensuring that simulated responses now correctly wrap event data within a result property.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue with SSE deserialization by correctly parsing the JSON-RPC response structure. The changes in the client logic are sound, and the accompanying updates to the sample application and unit tests are appropriate. I've suggested an improvement to the error handling in the SSE deserialization logic to make it more robust by explicitly handling JSON-RPC error responses.

@SergeyMenshykh SergeyMenshykh added this pull request to the merge queue Jul 8, 2025
Merged via the queue into a2aproject:main with commit 12187a0 Jul 8, 2025
4 checks passed
@SergeyMenshykh SergeyMenshykh deleted the fix-sse-deserialization branch July 8, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants