fix: fix sse deserialization#35
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @SergeyMenshykh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug in the deserialization of Server-Sent Events (SSE) by ensuring that the client correctly parses the event data from the result field of a JSON-RPC response. This change is crucial for the client to properly interpret and process incoming SSE messages, and it is supported by corresponding updates to the client sample application and unit tests to validate the new deserialization logic.
Highlights
- SSE Deserialization Fix: Modified the
A2AClientto correctly deserialize Server-Sent Events (SSE) by extracting the event data from theresultproperty of a JSON-RPC response, rather than attempting to deserialize the entire JSON object. This aligns with the expected JSON-RPC envelope for SSE data. - Client Sample Update: Enhanced the
Program.cssample client to includeMessageIdandContextIdwhen sending messages, and added specific handling forMessagetype events received via SSE, including printing message details and text parts. - Unit Test Adjustments: Updated several unit tests in
A2AClientTests.csto reflect the new JSON-RPC response structure for SSE events, ensuring that simulated responses now correctly wrap event data within aresultproperty.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes an issue with SSE deserialization by correctly parsing the JSON-RPC response structure. The changes in the client logic are sound, and the accompanying updates to the sample application and unit tests are appropriate. I've suggested an improvement to the error handling in the SSE deserialization logic to make it more robust by explicitly handling JSON-RPC error responses.
This PR fixes the deserialization of SSE events by polymorphically deserializing the event data from the result property (see the JSON example below) instead of the event(entire JSON object) itself:
{ "id": "4e5f4e5a-9b2c-485b-b6dc-4ddbeb1988d1", "jsonrpc": "2.0", "result": { "kind": "message", "messageId": "36818e79-700c-4795-a2e5-bf7f48f38fb3", "parts": [ { "kind": "text", "text": "Hello World" } ], "role": "agent" } }