Conversation
…of required one, etc
There was a problem hiding this comment.
Summary of Changes
Hello @SergeyMenshykh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a significant clean-up of the model classes, primarily by aligning their property definitions (names, types, and nullability) with the project's specification. A key part of this effort involves migrating from the RequiredAttribute to the JsonRequiredAttribute for JSON serialization validation, ensuring that required properties are correctly enforced during JSON processing.
Highlights
- Model Property Alignment: Properties across various model classes have been updated to match the specification, including changes from nullable types (e.g.,
string?,List<T>?,Dictionary<K,V>?) to non-nullable types with appropriate default initializations (e.g.,string.Empty,new List<T>(),new Dictionary<K,V>()). - JSON Serialization Validation: The
System.ComponentModel.DataAnnotations.RequiredAttributehas been systematically replaced withSystem.Text.Json.Serialization.JsonRequiredAttributein model classes, ensuring that JSON serialization and deserialization correctly enforce required fields. TaskPushNotificationConfigRenaming: TheIdproperty within theTaskPushNotificationConfigmodel has been renamed toTaskIdto improve clarity and consistency, with all references updated accordingly in the codebase, including theA2AHttpProcessor,InMemoryTaskStore, and various unit tests.- Sample HTTP Request Updates: Minor adjustments were made to the sample HTTP request files to reflect changes in API method names (e.g.,
task/gettotasks/get) and updated comment formatting.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request cleans up the data models to align with the specification by adjusting property names, types, nullability, and replacing RequiredAttribute with JsonRequiredAttribute. The changes are reflected in the updated tests. The model for FilePart seems to have become overly restrictive, no longer supporting file references by URI. Otherwise, the changes look good.
… to the FileContent base one.
This PR aligns the names, types, and nullability of properties in model classes with those from the specification. It also replaces all instances of the RequiredAttribute with the JsonRequiredAttribute.