Skip to content

Comments

feat: model clean-up#36

Merged
SergeyMenshykh merged 3 commits intoa2aproject:mainfrom
SergeyMenshykh:model-cleanup-1
Jul 9, 2025
Merged

feat: model clean-up#36
SergeyMenshykh merged 3 commits intoa2aproject:mainfrom
SergeyMenshykh:model-cleanup-1

Conversation

@SergeyMenshykh
Copy link
Collaborator

This PR aligns the names, types, and nullability of properties in model classes with those from the specification. It also replaces all instances of the RequiredAttribute with the JsonRequiredAttribute.

@SergeyMenshykh SergeyMenshykh self-assigned this Jul 8, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @SergeyMenshykh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant clean-up of the model classes, primarily by aligning their property definitions (names, types, and nullability) with the project's specification. A key part of this effort involves migrating from the RequiredAttribute to the JsonRequiredAttribute for JSON serialization validation, ensuring that required properties are correctly enforced during JSON processing.

Highlights

  • Model Property Alignment: Properties across various model classes have been updated to match the specification, including changes from nullable types (e.g., string?, List<T>?, Dictionary<K,V>?) to non-nullable types with appropriate default initializations (e.g., string.Empty, new List<T>(), new Dictionary<K,V>()).
  • JSON Serialization Validation: The System.ComponentModel.DataAnnotations.RequiredAttribute has been systematically replaced with System.Text.Json.Serialization.JsonRequiredAttribute in model classes, ensuring that JSON serialization and deserialization correctly enforce required fields.
  • TaskPushNotificationConfig Renaming: The Id property within the TaskPushNotificationConfig model has been renamed to TaskId to improve clarity and consistency, with all references updated accordingly in the codebase, including the A2AHttpProcessor, InMemoryTaskStore, and various unit tests.
  • Sample HTTP Request Updates: Minor adjustments were made to the sample HTTP request files to reflect changes in API method names (e.g., task/get to tasks/get) and updated comment formatting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the data models to align with the specification by adjusting property names, types, nullability, and replacing RequiredAttribute with JsonRequiredAttribute. The changes are reflected in the updated tests. The model for FilePart seems to have become overly restrictive, no longer supporting file references by URI. Otherwise, the changes look good.

@SergeyMenshykh SergeyMenshykh marked this pull request as ready for review July 8, 2025 21:40
@SergeyMenshykh SergeyMenshykh enabled auto-merge July 8, 2025 21:40
@SergeyMenshykh SergeyMenshykh linked an issue Jul 8, 2025 that may be closed by this pull request
@SergeyMenshykh SergeyMenshykh added this pull request to the merge queue Jul 9, 2025
Merged via the queue into a2aproject:main with commit c5a8b7e Jul 9, 2025
4 checks passed
@SergeyMenshykh SergeyMenshykh deleted the model-cleanup-1 branch July 9, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align A2A models with the spec

2 participants