Skip to content

Comments

feat: seal api and clean up a2aclient tests#37

Merged
SergeyMenshykh merged 5 commits intoa2aproject:mainfrom
SergeyMenshykh:seal-classes
Jul 9, 2025
Merged

feat: seal api and clean up a2aclient tests#37
SergeyMenshykh merged 5 commits intoa2aproject:mainfrom
SergeyMenshykh:seal-classes

Conversation

@SergeyMenshykh
Copy link
Collaborator

This PR seals public API and model classes, makes some of them abstract, and cleans up the unit tests for A2AClient.

@SergeyMenshykh SergeyMenshykh self-assigned this Jul 9, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @SergeyMenshykh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the robustness and clarity of the public API by explicitly defining class extensibility through the use of sealed and abstract keywords. Concurrently, it improves the maintainability of the A2AClient's unit tests by streamlining their setup and reducing duplication.

Highlights

  • API Design - Sealing Classes: A significant number of public API and model classes across A2A/JsonRpc, A2A/Models, and A2A/Server directories have been marked as sealed. This prevents external code from inheriting from these classes, promoting API stability and preventing unintended extensions.
  • API Design - Abstracting Base Classes: The A2AEvent and A2AResponse base classes in src/A2A/Models/A2AResponse.cs have been changed from concrete classes to abstract. This clarifies their role as base types that cannot be directly instantiated, enforcing proper inheritance patterns for derived event and response types.
  • Test Suite Refactoring: The unit tests for A2AClient in tests/A2A.UnitTests/Client/A2AClientTests.cs have undergone a substantial cleanup. The CreateA2AClient helper method has been refactored to centralize the mock HTTP client setup, reducing boilerplate and improving the readability and maintainability of the tests, especially for handling different response types (e.g., standard JSON-RPC vs. SSE).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request seals several classes and makes A2AEvent and A2AResponse abstract. It also cleans up the unit tests for A2AClient by using concrete types in CreateA2AClient.

@SergeyMenshykh SergeyMenshykh added this pull request to the merge queue Jul 9, 2025
Merged via the queue into a2aproject:main with commit 4d328ae Jul 9, 2025
4 checks passed
@SergeyMenshykh SergeyMenshykh deleted the seal-classes branch July 9, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants