-
Notifications
You must be signed in to change notification settings - Fork 105
Fix: fixing issues when running in a JakartaEE server. #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses issues encountered when running the SDK in a Jakarta EE server environment. The changes primarily involve configuring dependencies and enabling CDI to ensure proper bean management and dependency injection within the Jakarta EE container. The addition of beans.xml files and the modification of exception mappers and the JSONRPCHandler class are intended to resolve compatibility problems with Jakarta EE servers.
Highlights
- Dependency Management: Updated the
sdk-jakarta/pom.xmlto include<scope>provided</scope>forjakarta.enterprise.cdi-apiandjakarta.inject-apidependencies. This indicates that these dependencies are expected to be provided by the Jakarta EE server at runtime. - Exception Mapper Configuration: Modified
A2AServerResource.javato makeJsonParseExceptionMapperandJsonMappingExceptionMapperstatic inner classes and added empty constructor to each. This is likely to address issues with CDI injection in Jakarta EE environments. - CDI Beans Configuration: Added
beans.xmlfiles tosdk-jakarta/src/main/resources/META-INF/andsdk-server-common/src/main/resources/META-INF/. These files enable CDI (Contexts and Dependency Injection) for these modules, which is necessary for proper bean management in Jakarta EE. - JSONRPCHandler Constructor: Added an empty constructor to
JSONRPCHandler.java. This is likely to address issues with CDI injection in Jakarta EE environments.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves compatibility with Jakarta EE servers by setting dependency scopes to provided for Jakarta EE APIs, adding beans.xml files to enable CDI, and adjusting classes to be compliant with CDI and JAX-RS instantiation rules. Consider using a more performant CDI bean discovery mode and improving the encapsulation of a CDI bean's constructor.
sdk-server-common/src/main/java/io/a2a/server/requesthandlers/JSONRPCHandler.java
Outdated
Show resolved
Hide resolved
* Adding content in the beans.xml. * Adding empty constructors. Signed-off-by: Emmanuel Hugonnet <[email protected]>
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.Fixes #<issue_number_goes_here> 🦕