Skip to content

chore: fix build and CI #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maeste merged 2 commits into from
Jul 1, 2025
+3 −2
Merged

chore: fix build and CI #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72e3d8f
Fix build
kabir Jul 1, 2025
7fd8e43
-Dmaven.test.failure.ignore=true hides failures
kabir Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ jobs:
distribution: 'temurin'
cache: maven
- name: Build with Maven
run: mvn -B package --file pom.xml -Dmaven.test.failure.ignore=true -fae
run: mvn -B package --file pom.xml -fae
1 change: 1 addition & 0 deletions examples/helloworld/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<groupId>io.a2a.sdk</groupId>
<artifactId>a2a-java-sdk-parent</artifactId>
<version>0.2.4-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding relativePath fixes the build, but the artifactId (a2a-java-sdk-examples-parent on line 14) is now misleading, as it's within helloworld. Consider renaming to a2a-java-sdk-example-helloworld-parent for clarity. This requires updating the <parent> section in the client and server sub-modules.

</parent>

<artifactId>a2a-java-sdk-examples-parent</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@
<module>sdk-jakarta</module>
<module>sdk-quarkus</module>
<module>tck</module>
<module>examples</module>
<module>examples/helloworld</module>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Listing each example module individually in the root pom.xml might become cumbersome as more examples are added. Consider introducing an aggregator POM at examples/pom.xml with a single <module>examples</module> entry in the root pom.xml to manage example modules centrally.

<module>tests/server-common</module>
</modules>
</project>