Skip to content

Conversation

@ehsavoie
Copy link
Collaborator

@ehsavoie ehsavoie commented Jul 3, 2025

@ApplicationScoped so that it becomes a stereotype and can be discovered using bean-discovery-mode="annotated" instead of "all".

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • [C] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • [C] Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ApplicationScoped so that it becomes a stereotype and can be discovered
using bean-discovery-mode="annotated" instead of "all".

Signed-off-by: Emmanuel Hugonnet <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the CDI configuration to optimize bean discovery within the application. By transitioning a key producer to @ApplicationScoped and narrowing the bean-discovery-mode in beans.xml to annotated, the changes aim to improve application startup times and resource utilization by making the CDI container more efficient in identifying and managing beans.

Highlights

  • CDI Bean Scope Update: The AsyncExecutorProducer class has been updated from using the @Singleton annotation to @ApplicationScoped. This change allows the producer to be discovered when the CDI bean-discovery-mode is set to annotated, aligning with a more optimized bean discovery strategy.
  • CDI Bean Discovery Mode Refinement: The beans.xml configuration file has been modified to change the bean-discovery-mode from all to annotated. This ensures that only classes explicitly annotated with CDI bean-defining annotations (like @ApplicationScoped) are discovered, improving startup performance and reducing the memory footprint of the CDI container.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors the AsyncExecutorProducer to use the standard CDI @ApplicationScoped annotation in place of @Singleton. This change, combined with updating the bean-discovery-mode to annotated in beans.xml, is a good practice that can improve application startup performance by optimizing the bean discovery process. The changes are sound and represent a positive improvement to the codebase.

@kabir kabir merged commit 33b8e77 into a2aproject:main Jul 3, 2025
2 checks passed
@ehsavoie ehsavoie deleted the fix_cdi_warning branch December 11, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants