-
Notifications
You must be signed in to change notification settings - Fork 105
feat: Add a2a-tck runs to CI for PRs (GH-152) #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a2a-tck runs to CI for PRs (GH-152) #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dev-jonghoonpark, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request integrates the a2a-tck (Test Compatibility Kit) into the project's GitHub Actions CI workflow. The primary goal is to ensure that all future pull requests automatically run the TCK tests, enhancing the reliability and compatibility of the a2a-java project by catching regressions early and ensuring adherence to the a2a specification.
Highlights
- CI Integration: Configured the GitHub Actions workflow to include
a2a-tcktest runs for pull requests, ensuring automated compatibility checks for thea2a-javaproject. - Dependency Management: Added the
quarkus-smallrye-healthdependency totck/pom.xml, which likely enables health check endpoints for the TCK application itself. - TCK Configuration: Updated
tck/src/main/resources/application.propertiesto configure Quarkus production profile settings, including HTTP and management ports, and enabling the management interface for the TCK application.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request integrates the a2a-tck tests into the CI pipeline by adding the quarkus-smallrye-health dependency and configuring Quarkus production properties for the TCK server. The changes are generally well-aligned with the goal of enabling CI runs. A potential issue with the management host binding in containerized environments has been identified.
3b2ade0 to
1ae6ab4
Compare
kabir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dev-jonghoonpark, thanks for the contribution!
I actually also opened #163 for this, but we can use yours since yours came first. So I have closed mine.
A few small suggestions thanks!
1ae6ab4 to
34a82e4
Compare
|
@kabir While working on it, I also wanted to separate the 'Wait for server to start' step and the 'Run TCK' step like you did. Did you happen to encounter any issues with this when you tested it? |
|
No, but then I just tried it a few times (i had a very hard time with the wait for server step, until I googled the We can look more on Monday? |
|
Certainly. Thank you. : ) |
Signed-off-by: jonghoonpark <[email protected]>
34a82e4 to
4b3e1cf
Compare
|
Hi @dev-jonghoonpark since I am a project admin, I took the liberty to rebase your PR on main, and add a commit which splits starting Quarkus, waiting for it to start and running the TCK into separate steps. Hope you don't mind :-) I think we will merge it as soon as possible. If you don't see this before it is merged, and you have some concerns, please raise those as a follow-up PR ? |
|
Of course, no worries! If everything worked fine in your testing process, Thank you :) |
|
Ah ok, I've not tried act in years. I just try out these things in my private repo, and it works like this there |
Description
Added the a2a-tck test to the GitHub Actions workflow of the
a2a-javaproject.Tested locally using the following commands.
Fixes #152 🦕