Skip to content

Conversation

@dev-jonghoonpark
Copy link
Contributor

Description

Added the a2a-tck test to the GitHub Actions workflow of the a2a-java project.

Tested locally using the following commands.

act -P ubuntu-latest=quay.io/jamezp/act-maven -W '.github/workflows/tck-test.yml' 

Fixes #152 🦕

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dev-jonghoonpark, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the a2a-tck (Test Compatibility Kit) into the project's GitHub Actions CI workflow. The primary goal is to ensure that all future pull requests automatically run the TCK tests, enhancing the reliability and compatibility of the a2a-java project by catching regressions early and ensuring adherence to the a2a specification.

Highlights

  • CI Integration: Configured the GitHub Actions workflow to include a2a-tck test runs for pull requests, ensuring automated compatibility checks for the a2a-java project.
  • Dependency Management: Added the quarkus-smallrye-health dependency to tck/pom.xml, which likely enables health check endpoints for the TCK application itself.
  • TCK Configuration: Updated tck/src/main/resources/application.properties to configure Quarkus production profile settings, including HTTP and management ports, and enabling the management interface for the TCK application.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates the a2a-tck tests into the CI pipeline by adding the quarkus-smallrye-health dependency and configuring Quarkus production properties for the TCK server. The changes are generally well-aligned with the goal of enabling CI runs. A potential issue with the management host binding in containerized environments has been identified.

@dev-jonghoonpark dev-jonghoonpark force-pushed the feat/add-a2a-tck-runs-to-ci-for-prs branch from 3b2ade0 to 1ae6ab4 Compare July 4, 2025 15:48
kabir
kabir previously requested changes Jul 4, 2025
Copy link
Collaborator

@kabir kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dev-jonghoonpark, thanks for the contribution!

I actually also opened #163 for this, but we can use yours since yours came first. So I have closed mine.

A few small suggestions thanks!

@dev-jonghoonpark dev-jonghoonpark force-pushed the feat/add-a2a-tck-runs-to-ci-for-prs branch from 1ae6ab4 to 34a82e4 Compare July 4, 2025 17:02
@dev-jonghoonpark
Copy link
Contributor Author

@kabir
Thank you for your feedback.
I’ve made the changes based on your comments and your PR, and pushed the updates.


While working on it, I also wanted to separate the 'Wait for server to start' step and the 'Run TCK' step like you did.
However, when I separated the steps, the server would shut down before the TCK run step.
So I ended up combining them into a single step.

Did you happen to encounter any issues with this when you tested it?

@kabir
Copy link
Collaborator

kabir commented Jul 4, 2025

No, but then I just tried it a few times (i had a very hard time with the wait for server step, until I googled the || true trick).

We can look more on Monday?

@dev-jonghoonpark
Copy link
Contributor Author

Certainly. Thank you. : )

@kabir kabir force-pushed the feat/add-a2a-tck-runs-to-ci-for-prs branch from 34a82e4 to 4b3e1cf Compare July 7, 2025 12:37
@kabir
Copy link
Collaborator

kabir commented Jul 7, 2025

Hi @dev-jonghoonpark since I am a project admin, I took the liberty to rebase your PR on main, and add a commit which splits starting Quarkus, waiting for it to start and running the TCK into separate steps.

Hope you don't mind :-)

I think we will merge it as soon as possible. If you don't see this before it is merged, and you have some concerns, please raise those as a follow-up PR ?

@kabir kabir dismissed their stale review July 7, 2025 12:56

Done

@dev-jonghoonpark
Copy link
Contributor Author

@kabir

Of course, no worries!
I agree with your approach, and I also think that direction makes much more sense as long as there are no issues.

If everything worked fine in your testing process,
then the issue might be specific to act, which I used for local testing.

Thank you :)
Hope you have a great day!

@kabir
Copy link
Collaborator

kabir commented Jul 7, 2025

Ah ok, I've not tried act in years. I just try out these things in my private repo, and it works like this there

@kabir kabir merged commit a31d73a into a2aproject:main Jul 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a2a-tck runs to CI for PRs

2 participants