fix: client sse #177
fix: client sse #177
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ChenKangQiang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug in the client's Server-Sent Events (SSE) implementation. Previously, the client failed to include the necessary text/event-stream content type when sending stream messages, leading to improper SSE communication. The fix ensures that the correct content type is set, enabling reliable streaming functionality.
Highlights
- Bug Fix: Corrected the
getAsyncSSEmethod inJdkA2AHttpClient.javato properly set thetext/event-streamcontent type. This was achieved by changing the argument passed tocreateRequestBuilderfromfalsetotrue, ensuring correct Server-Sent Events (SSE) communication.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request fixes an issue where the Accept: text/event-stream header was not being set for Server-Sent Events (SSE) GET requests. The review points out that the same issue exists for POST requests in postAsyncSSE and should also be fixed to ensure consistent behavior for all streaming requests.
| Consumer<Throwable> errorConsumer, | ||
| Runnable completeRunnable) throws IOException, InterruptedException { | ||
| HttpRequest request = createRequestBuilder(false) | ||
| HttpRequest request = createRequestBuilder(true) |
There was a problem hiding this comment.
The Accept header is correctly set for SSE GET requests. However, a similar issue exists for POST requests. The postAsyncSSE method calls createRequestBuilder(false), preventing the Accept: text/event-stream header from being set for streaming POST requests. To ensure consistency, apply a similar fix to postAsyncSSE.
| HttpRequest request = createRequestBuilder(true) | |
| HttpRequest request = createRequestBuilder(true) | |
| .build(); |
There was a problem hiding this comment.
@ChenKangQiang Thanks for the PR! A similar change should also be made in the postAsyncSSE method as mentioned here.
There was a problem hiding this comment.
ok. now i have fix
|
Thanks @ChenKangQiang! |
fix client send stream message without set text/event-stream. # Description Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md). - [ ] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification. - Important Prefixes for [release-please](https://github.com/googleapis/release-please): - `fix:` which represents bug fixes, and correlates to a [SemVer](https://semver.org/) patch. - `feat:` represents a new feature, and correlates to a SemVer minor. - `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking change (indicated by the `!`) and will result in a SemVer major. - [ ] Ensure the tests pass - [ ] Appropriate READMEs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕 --------- Co-authored-by: chenkangqiang <[email protected]>
3 participants
fix client send stream message without set text/event-stream.
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.Fixes #<issue_number_goes_here> 🦕