feat: Externalise sdk-jakarta, add list of integrations and make Quarkus reference implementation #178
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request re-architects the A2A Java SDK's server implementation strategy by externalizing the Jakarta-based SDK, establishing the Quarkus-based SDK as the official reference implementation, and introducing a clear framework for community contributions of server integrations. This makes the project more modular, extensible, and clarifies the role of different server implementations.
Highlights
- Server Implementation Restructuring: The project's server implementation strategy has been significantly revised. The
sdk-jakartamodule has been externalized, indicating a shift towards community-driven integrations for specific runtimes. Thesdk-quarkusmodule has been repurposed and renamed toreference-impl, establishing it as the primary, in-house reference implementation. - Quarkus as Reference Implementation: The Quarkus-based server implementation is now officially designated as the
a2a-java-reference-server. This module will serve as the main example and testbed for the A2A Java SDK, and itspom.xmlandREADME.mdhave been updated to reflect this new role. - Integration Contribution Guidelines: A new file,
CONTRIBUTING_INTEGRATIONS.md, has been added to provide clear guidelines for community members who wish to contribute and list their own A2A SDK server integrations. This includes requirements for documentation, samples, testing, and TCK compliance. - Updated Documentation and Dependencies: The
README.mdhas been updated to reflect these architectural changes, removing direct mentions of thesdk-jakartadependency and updating the Quarkus dependency to the newa2a-java-reference-serverartifact. A new 'Server Integrations' section has been added, listing available integrations and linking to the new contribution guidelines. Projectpom.xmlfiles (root, examples, TCK) have been updated to use the newa2a-java-reference-serverartifact ID.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors the project structure by externalizing the sdk-jakarta module and rebranding the sdk-quarkus module as the reference-impl. It also introduces a new CONTRIBUTING_INTEGRATIONS.md file and a corresponding section in the main README.md to encourage community contributions for server integrations. The changes in pom.xml files and documentation are consistent with this goal.
|
/gemini review |
There was a problem hiding this comment.
Code Review
The pull request focuses on reorganizing the project structure by externalizing the sdk-jakarta module, renaming sdk-quarkus to reference-impl, and updating related documentation. The changes enhance clarity regarding runtime integration options and contribution guidelines.
| and allow you to run your agentic Java application as an A2A server agent. | ||
|
|
||
| The A2A Java SDK provides two A2A server endpoint implementations, one based on Jakarta REST (`a2a-java-sdk-server-jakarta`) and one based on Quarkus Reactive Routes (`a2a-java-sdk-server-quarkus`). You can choose the one that best fits your application. | ||
| The A2A Java SDK provides a [reference A2A server implementation](reference-impl/README.md) based on [Quarkus](https://quarkus.io) for use with our tests and examples. However, the project is designed in such a way that it is trivial to integrate with various Java runtimes. |
There was a problem hiding this comment.
Consider rephrasing to clarify that the reference implementation is just one option, and other runtimes can be integrated. This highlights the flexibility of the SDK. For example: "The A2A Java SDK provides a reference A2A server implementation based on Quarkus for use with our tests and examples. However, the project is designed to be runtime-agnostic and easily integrated with various Java runtimes."
README.md
Outdated
| The A2A Java SDK provides a [reference A2A server implementation](reference-impl/README.md) based on [Quarkus](https://quarkus.io) for use with our tests and examples. However, the project is designed in such a way that it is trivial to integrate with various Java runtimes. | ||
|
|
||
| Add **one** of the following dependencies to your project: | ||
| [Server Integrations](#server-integrations) contains a list of integrations of the server with various runtimes. You might be able to use one of these for your target runtime, or you can use them as inspiration to create your own. |
There was a problem hiding this comment.
Consider adding a brief description of what the integrations provide, such as "community-contributed integrations".
kabir
force-pushed
the
external-jakarta
branch
7 times, most recently
from
0ac8c50 to
e971785
Compare
…kus reference implementation (a2aproject#178) # Description Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md). - [x] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification. - Important Prefixes for [release-please](https://github.com/googleapis/release-please): - `fix:` which represents bug fixes, and correlates to a [SemVer](https://semver.org/) patch. - `feat:` represents a new feature, and correlates to a SemVer minor. - `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking change (indicated by the `!`) and will result in a SemVer major. - [x] Ensure the tests pass - [x] Appropriate READMEs were updated (if necessary) Fixes a2aproject#176 🦕
2 participants
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.Fixes #176 🦕