fix: Incorporate latest feedback from https://github.com/a2aproject/a2a-java/pull/138 #182
Conversation
…te final in A2ACardResolver
…uest body to JSON and checks the method attribute Remove A2AServerRoutes#isNonStreamingRequest since it's unused
…tAggregator#consumeAndBreakOnInterrupt
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @fjuma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request incorporates feedback from a previous PR to enhance the robustness and correctness of URL handling in the client, improve JSON request parsing in the server, and refine asynchronous processing in the SDK. These changes collectively aim to make the codebase more reliable and maintainable.
Highlights
- Improved URL Handling and Validation: The
A2ACardResolverclass now usesjava.net.URIfor more robust and correct construction of agent card URLs, replacing manual string concatenation and slash handling. This change also introducesA2AClientErrorexceptions for invalid base URLs, ensuring better error propagation. - Refactored Request Type Detection: In
A2AServerRoutes, the logic for determining if a request is a 'streaming' request has been improved. Instead of simple string containment checks, the method now parses the request body as JSON to accurately extract and compare the 'method' field, making the detection more reliable. The redundantisNonStreamingRequestmethod was removed. - Asynchronous Event Consumption: The
ResultAggregatorclass in the SDK server common module now handles thecontinueConsumingcall asynchronously usingCompletableFuture.runAsync. This addresses a previousTODOcomment and aligns the Java implementation with the intended non-blocking behavior observed in the Python reference, preventing potential blocking issues. - Test Code Alignment: The
A2ACardResolverTesthas been updated to reflect the changes inA2ACardResolver, including adjusting imports, moving constants to the test class, and updating assertions to use the new local constants, ensuring the tests remain accurate and relevant.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request incorporates feedback from a previous one, resulting in improvements. The URL resolution logic is more robust, streaming request detection is more reliable, and a potential concurrency issue has been resolved. The review identifies a minor issue in the test suite where redundant test cases can be removed to improve clarity.
| resolver = new A2ACardResolver(client, "http://example.com/", AGENT_CARD_PATH.substring(0)); | ||
| card = resolver.getAgentCard(); | ||
|
|
||
| assertEquals("http://example.com" + A2ACardResolver.DEFAULT_AGENT_CARD_PATH, client.url); | ||
| assertEquals("http://example.com" + AGENT_CARD_PATH, client.url); | ||
|
|
||
| resolver = new A2ACardResolver(client, "http://example.com", A2ACardResolver.DEFAULT_AGENT_CARD_PATH.substring(0)); | ||
| resolver = new A2ACardResolver(client, "http://example.com", AGENT_CARD_PATH.substring(0)); | ||
| card = resolver.getAgentCard(); | ||
|
|
||
| assertEquals("http://example.com" + A2ACardResolver.DEFAULT_AGENT_CARD_PATH, client.url); | ||
| assertEquals("http://example.com" + AGENT_CARD_PATH, client.url); |
There was a problem hiding this comment.
These test cases are redundant because AGENT_CARD_PATH.substring(0) returns the original string, making these blocks duplicates of lines 42-50. Removing them will improve test clarity.
There was a problem hiding this comment.
Added comments to make the test cases more clear and fixed the tests that were using .substring(0) instead of .substring(1).
… clear and fix some tests
# Description This PR incorporates the latest feedback from a2aproject#138. - [x] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md). - [x] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification. - Important Prefixes for [release-please](https://github.com/googleapis/release-please): - `fix:` which represents bug fixes, and correlates to a [SemVer](https://semver.org/) patch. - `feat:` represents a new feature, and correlates to a SemVer minor. - `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking change (indicated by the `!`) and will result in a SemVer major. - [x] Ensure the tests pass - [x] Appropriate READMEs were updated (if necessary)
2 participants
Description
This PR incorporates the latest feedback from #138.
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.