Skip to content

Conversation

@mbroz2
Copy link
Contributor

@mbroz2 mbroz2 commented Jul 25, 2025

Description

The current helloworld example only ends up printing Response: io.a2a.spec.SendMessageResponse@63252cf7 when it does System.out.println("Response: " + response.toString());. I expect the actual intent to be to print the response message sent by the Agent which is what this update does.

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)
    • The current helloworld example READMEs (client and server) seem to need work beyond this minor update. Happy to handle that under another Issue/PR if strategic and helpful.

Fixes #<issue_number_goes_here> 🦕

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @mbroz2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the HelloWorldClient example to correctly parse and display the actual text content returned from the agent. Previously, the example only printed the toString() representation of the SendMessageResponse object, which wasn't very informative. This change makes the example more useful by demonstrating how to extract and show the real message content received from the agent.

Highlights

  • Improved Response Handling: The HelloWorldClient example now correctly extracts and prints the text content from the SendMessageResponse object, providing a more meaningful output.
  • New Imports: Necessary imports for EventKind, Part, and TextPart were added to facilitate the proper parsing and extraction of message content.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mbroz2 mbroz2 changed the title Update Example to print the actual response returned from Agent chore: Update Example to print the actual response returned from Agent Jul 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the HelloWorld example client to correctly parse and print the text content from the agent's response message, instead of just printing the response object's toString() representation. The implementation is correct, but I've suggested some minor refactoring to simplify the code by using modern Java features like pattern matching for instanceof and removing some redundant checks. This will make the example code cleaner and more idiomatic.

Comment on lines 58 to 69
if (result instanceof Message && result.getKind().equals(Message.MESSAGE)) {
Message responseMessage = (Message) result;
StringBuilder textBuilder = new StringBuilder();
if (responseMessage.getParts() != null) {
for (Part part : responseMessage.getParts()) {
if (part instanceof TextPart textPart) {
textBuilder.append(textPart.getText());
}
}
}
System.out.println("Response: " + textBuilder.toString());
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for processing the response message can be simplified for better readability and to follow modern Java practices.

  • You can use pattern matching for instanceof to avoid the explicit cast. This is already used on line 63.
  • The check result.getKind().equals(Message.MESSAGE) is redundant. The Message class constructor ensures the kind is always "message", so instanceof Message is sufficient.
  • The null check for responseMessage.getParts() is also redundant. The Message constructor ensures the parts list is not null.
  • It's good practice to use the generic type Part<?> instead of the raw type Part in the for-each loop to match the return type of getParts() and avoid compiler warnings.
            if (result instanceof Message responseMessage) {
                StringBuilder textBuilder = new StringBuilder();
                for (Part<?> part : responseMessage.getParts()) {
                    if (part instanceof TextPart textPart) {
                        textBuilder.append(textPart.getText());
                    }
                }
                System.out.println("Response: " + textBuilder.toString());
            }

@kabir kabir merged commit af34181 into a2aproject:main Aug 6, 2025
3 checks passed
kabir pushed a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
a2aproject#203)

# Description
The current helloworld example only ends up printing `Response:
io.a2a.spec.SendMessageResponse@63252cf7` when it does
`System.out.println("Response: " + response.toString());`. I expect the
actual intent to be to print the response message sent by the Agent
which is what this update does.

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make
sure it goes smoothly:

- [X] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md).
- [X] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- Important Prefixes for
[release-please](https://github.com/googleapis/release-please):
- `fix:` which represents bug fixes, and correlates to a
[SemVer](https://semver.org/) patch.
- `feat:` represents a new feature, and correlates to a SemVer minor.
- `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking
change (indicated by the `!`) and will result in a SemVer major.
- [X] Ensure the tests pass
- [X] Appropriate READMEs were updated (if necessary)
- The current helloworld example READMEs (client and server) seem to
need work beyond this minor update. Happy to handle that under another
Issue/PR if strategic and helpful.

Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants