-
Notifications
You must be signed in to change notification settings - Fork 104
feat: add default noop providers for AgentCard and -Executor #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces default, non-functional CDI bean producers for AgentCard and AgentExecutor within the Quarkus application context. The primary goal is to prevent build-time injection failures in Quarkus applications while still requiring developers to supply their own functional implementations for these core components at runtime.
Highlights
- CDI Injection Fix: I've added a new class,
DefaultProducers.java, to provide default 'no-op' CDI beans forAgentCardandAgentExecutor. This addresses a known issue (Issue #213) where Quarkus applications could encounter injection failures if these beans were not explicitly provided. - Default Bean Implementation: The new default beans are annotated with Quarkus's
@DefaultBean, ensuring they are used only if no other concrete implementation is available. If these default beans are ever invoked, they will throw anIllegalStateException, clearly guiding developers to provide their own custom implementations. - Guidance for Developers: The exception messages thrown by the default producers explicitly inform the user that they need to provide their own
AgentCardandAgentExecutorimplementations as CDI beans, and that their custom beans will automatically take precedence.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces default CDI producers for AgentCard and AgentExecutor to prevent injection issues in Quarkus applications when these beans are not yet implemented by the user. The approach of providing default beans that throw an IllegalStateException at runtime is a good pattern to guide developers. The implementation is straightforward.
reference-impl/src/main/java/io/a2a/server/apps/quarkus/DefaultProducers.java
Show resolved
Hide resolved
This avoids CDI injection problems when building an application with the Quarkus plugin, and still makes people have to implement them to run their application
…ect#215) This avoids CDI injection problems when building an application with the Quarkus plugin, and still makes people have to implement them to run their application # Description Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md). - [x] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification. - Important Prefixes for [release-please](https://github.com/googleapis/release-please): - `fix:` which represents bug fixes, and correlates to a [SemVer](https://semver.org/) patch. - `feat:` represents a new feature, and correlates to a SemVer minor. - `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking change (indicated by the `!`) and will result in a SemVer major. - [x] Ensure the tests pass - [x] Appropriate READMEs were updated (if necessary) Fixes a2aproject#213
This avoids CDI injection problems when building an application with the Quarkus plugin, and still makes people have to implement them to run their application
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.Fixes #213