fix: card resolver

[ChenKangQiang]

Description

Fix card resolver. For example，when agentUrl is http://localhost:8089/a2a/server, the agent card url is not working normally.

• Follow the CONTRIBUTING Guide.
• Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Important Prefixes for release-please:
    • fix: which represents bug fixes, and correlates to a SemVer patch.
    • feat: represents a new feature, and correlates to a SemVer minor.
    • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
• Ensure the tests pass
• Appropriate READMEs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

[gemini-code-assist]

Summary of Changes

Hello @ChenKangQiang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the A2ACardResolver that prevented agent card URLs from resolving correctly, particularly when the agentUrl did not have a trailing slash. The fix ensures robust URL construction by normalizing base URLs and agent card paths before resolution, making the card URLs work as expected.

Highlights

• Improved URL Resolution: Modified the A2ACardResolver to correctly handle baseUrl and agentCardPath formats.
• Path Normalization: Added logic to ensure baseUrl always ends with a trailing slash and agentCardPath does not start with a leading slash, preventing incorrect URI resolution.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue with URL resolution for the agent card by normalizing the base URL and the agent card path before combining them. The approach correctly addresses the problem where parts of the base URL path could be dropped. The logic is sound. I've added one suggestion to make the code for normalizing the agent card path slightly more concise.

[gemini-code-assist]

The logic to determine the effective agentCardPath and ensure it's a relative path is correct. However, it can be expressed more concisely by combining the ternary operator for the default value with another one for stripping the leading slash. This can make the code slightly cleaner and easier to read.

        String path = (agentCardPath == null || agentCardPath.isEmpty()) ? DEFAULT_AGENT_CARD_PATH : agentCardPath;
        agentCardPath = path.startsWith("/") ? path.substring(1) : path;

[fjuma]

Hi @ChenKangQiang, thanks for the PR. This looks like a duplicate of #191 and #189. As discussed there, it was determined that this isn't a bug.

[fjuma]

I'm going to close this for now. Feel free to continue the discussion on the issues if needed. Thanks.