chore: Add Jspecify NullCheck in tck module #336

[ethanthopkins]

…y @nullable annotation to AgentCardProducer, getEnvOrDefault Method and AgentExecutorProducer execute Method. Fixes #336

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Follow the CONTRIBUTING Guide.
• Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Important Prefixes for release-please:
    • fix: which represents bug fixes, and correlates to a SemVer patch.
    • feat: represents a new feature, and correlates to a SemVer minor.
    • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
• Ensure the tests pass
• Appropriate READMEs were updated (if necessary)

Fixes #336 🦕

[gemini-code-assist]

Summary of Changes

Hello @ethanthopkins, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the null safety of the tck module by integrating JSpecify annotations. By explicitly marking nullable parameters and enabling package-level nullness checking, the changes aim to improve code reliability and prevent potential NullPointerExceptions at compile time, aligning with modern Java best practices for type safety.

Highlights

• JSpecify Nullness Annotations: Introduced JSpecify's @Nullable annotation to specific method parameters in AgentCardProducer and AgentExecutorProducer to explicitly mark potentially null values.
• Package-level Null Marking: Enabled package-level nullness checking for io.a2a.tck.server by adding a package-info.java file with the @NullMarked annotation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces JSpecify nullness annotations to the tck module by marking the io.a2a.tck.server package as @NullMarked. While this is a good step towards improving code safety, there are a couple of instances where @Nullable has been applied to parameters, but the method implementations do not handle null values, which would lead to NullPointerExceptions at runtime. My review includes critical feedback to address these issues.

[ethanthopkins]

I removed the two @nullable annotations that I had included because I realized that the null values where not handled.

[ehsavoie]

May you please squash the commits and remove unused imports

[ehsavoie]

May you please squash the commits and remove unused imports

[ethanthopkins]

The commits were squashed and the unused imports where removed :)

[fjuma]

Thanks @ethanthopkins!