Skip to content

Conversation

@ehsavoie
Copy link
Collaborator

Reverts #341

@ehsavoie ehsavoie merged commit f58d94b into main Oct 21, 2025
9 of 11 checks passed
@ehsavoie ehsavoie deleted the revert-341-add-protoutil-tests branch October 21, 2025 11:50
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request serves to undo a previous set of changes that introduced new test cases for the ToProto and FromProto utility classes. The primary impact is the removal of a dedicated test file, FromProtoTest.java, and a specific test method from ToProtoTest.java, effectively streamlining the test suite by rolling back these additions.

Highlights

  • Test Reversion: This pull request fully reverts the changes introduced in test: add ToProto and FromProto tests #341, which had added new tests for ToProto and FromProto utilities.
  • File Removal: The FromProtoTest.java file, containing tests for FromProto utility methods, has been entirely removed from the codebase.
  • Test Case Removal: A specific test case, testToProtoPartUnsupportedType, has been removed from the ToProtoTest.java file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous change, removing tests for ToProto and FromProto utility methods. While the original tests may have had issues, completely removing them is not ideal as it reduces test coverage for ProtoUtils, increasing the risk of future regressions. It would be preferable to fix the tests or replace them to ensure the utility methods are behaving as expected, especially around edge cases like handling unsupported types or malformed inputs.

kabir pushed a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants