Skip to content

fix: Clean up the k8s example pom, and the extras application properties #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabir merged 1 commit into from
Oct 30, 2025
+6 −32
Merged

fix: Clean up the k8s example pom, and the extras application properties #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 6 additions & 23 deletions examples/cloud-deployment/server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<description>Example demonstrating A2A agent deployment in Kubernetes with database persistence and event replication</description>

<dependencies>
<!-- Core A2A SDK with JSON-RPC transport -->
<!-- Core A2A SDK with JSON-RPC transport. This pulls in the rest of the needed a2a-java dependencies -->
<dependency>
<groupId>io.github.a2asdk</groupId>
<artifactId>a2a-java-sdk-reference-jsonrpc</artifactId>
Expand Down Expand Up @@ -45,14 +45,17 @@
<version>${project.version}</version>
</dependency>

<!-- Replicated queue manager with Kafka via MicroProfile Reactive Messaging -->
<!-- Provides the MicroProfile Reactive Messaging ReplicationStrategy for the replicated queue manager-->
<dependency>
<groupId>io.github.a2asdk</groupId>
<artifactId>a2a-java-queue-manager-replication-mp-reactive</artifactId>
<version>${project.version}</version>
</dependency>

<!-- Quarkus Kafka connector for MicroProfile Reactive Messaging -->
<!--
MicroProfile Reactive Messaging support including the Kafka connector, used by the MP RM
ReplicationStrategy
-->
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-messaging-kafka</artifactId>
Expand All @@ -70,32 +73,12 @@
<artifactId>quarkus-hibernate-orm</artifactId>
</dependency>

<!-- Quarkus REST/JAX-RS -->
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy-jackson</artifactId>
</dependency>

<!-- Quarkus Health checks -->
<dependency>
Comment on lines 73 to 77
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These dependencies are no longer needed and can be removed to reduce the size of the application and improve build times. Removing unused dependencies helps in maintaining a cleaner and more efficient project structure.

        <dependency>
            <groupId>io.quarkus</groupId>
            <artifactId>quarkus-resteasy-jackson</artifactId>
        </dependency>

        <!-- Quarkus Health checks -->
        <dependency>
            <groupId>io.quarkus</groupId>
            <artifactId>quarkus-smallrye-health</artifactId>
        </dependency>

Copy link
Collaborator Author

@kabir kabir Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are needed, and Jackson is removed

<groupId>io.quarkus</groupId>
<artifactId>quarkus-smallrye-health</artifactId>
</dependency>

<!-- CDI API (provided by Quarkus) -->
<dependency>
<groupId>jakarta.enterprise</groupId>
<artifactId>jakarta.enterprise.cdi-api</artifactId>
<scope>provided</scope>
</dependency>

<!-- Logging -->
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>


<dependency>
<groupId>io.github.a2asdk</groupId>
<artifactId>a2a-java-sdk-client</artifactId>
Expand Down
3 changes: 0 additions & 3 deletions ...r-replicated/tests-multi-instance/quarkus-app-1/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
# Application HTTP Port
quarkus.http.port=8081

# Select our ReplicatedQueueManager and JpaDatabaseTaskStore as the active implementations
quarkus.arc.selected-alternatives=io.a2a.extras.queuemanager.replicated.core.ReplicatedQueueManager,io.a2a.extras.taskstore.database.jpa.JpaDatabaseTaskStore

# Configure PostgreSQL database (connection details will be provided by Testcontainers)
quarkus.datasource."a2a-java".db-kind=postgresql
Comment on lines 4 to 5
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These properties are no longer needed and can be removed to simplify the configuration. Removing unused properties helps in maintaining a cleaner and more efficient configuration.

# Select our ReplicatedQueueManager and JpaDatabaseTaskStore as the active implementations
quarkus.arc.selected-alternatives=io.a2a.extras.queuemanager.replicated.core.ReplicatedQueueManager,io.a2a.extras.taskstore.database.jpa.JpaDatabaseTaskStore

Copy link
Collaborator Author

@kabir kabir Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed them, and you are telling me to remove them :-)

quarkus.datasource."a2a-java".jdbc.url=${DATABASE_URL:jdbc:postgresql://localhost:5432/a2adb}
Expand Down
3 changes: 0 additions & 3 deletions ...r-replicated/tests-multi-instance/quarkus-app-2/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
# Application HTTP Port
quarkus.http.port=8082

# Select our ReplicatedQueueManager and JpaDatabaseTaskStore as the active implementations
quarkus.arc.selected-alternatives=io.a2a.extras.queuemanager.replicated.core.ReplicatedQueueManager,io.a2a.extras.taskstore.database.jpa.JpaDatabaseTaskStore

# Configure PostgreSQL database (connection details will be provided by Testcontainers)
quarkus.datasource."a2a-java".db-kind=postgresql
Comment on lines 4 to 5
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These properties are no longer needed and can be removed to simplify the configuration. Removing unused properties helps in maintaining a cleaner and more efficient configuration.

# Select our ReplicatedQueueManager and JpaDatabaseTaskStore as the active implementations
quarkus.arc.selected-alternatives=io.a2a.extras.queuemanager.replicated.core.ReplicatedQueueManager,io.a2a.extras.taskstore.database.jpa.JpaDatabaseTaskStore

Copy link
Collaborator Author

@kabir kabir Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are actually being removed!

quarkus.datasource."a2a-java".jdbc.url=${DATABASE_URL:jdbc:postgresql://localhost:5432/a2adb}
Expand Down
3 changes: 0 additions & 3 deletions .../queue-manager-replicated/tests-single-instance/src/test/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# Select our ReplicatedQueueManager as the active implementation
quarkus.arc.selected-alternatives=io.a2a.extras.queuemanager.replicated.core.ReplicatedQueueManager,io.a2a.extras.taskstore.database.jpa.JpaDatabaseTaskStore

# Configure in-memory H2 database for testing
quarkus.datasource."a2a-java".db-kind=h2
Comment on lines 1 to 2
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This property is no longer needed and can be removed to simplify the configuration. Removing unused properties helps in maintaining a cleaner and more efficient configuration.

# Select our ReplicatedQueueManager as the active implementation
quarkus.arc.selected-alternatives=io.a2a.extras.queuemanager.replicated.core.ReplicatedQueueManager,io.a2a.extras.taskstore.database.jpa.JpaDatabaseTaskStore

Copy link
Collaborator Author

@kabir kabir Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am removing them

quarkus.datasource."a2a-java".jdbc.url=jdbc:h2:mem:test
Expand Down
Loading