Skip to content

Comments

chore: Next is 0.3.3#443

Closed
kabir wants to merge 2 commits intoa2aproject:0.3.xfrom
kabir:bump-0.3.3
Closed

chore: Next is 0.3.3#443
kabir wants to merge 2 commits intoa2aproject:0.3.xfrom
kabir:bump-0.3.3

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Nov 4, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on a routine version update for the project. It involves incrementing the project's snapshot version across various modules and examples, ensuring consistency in dependency declarations. This change prepares the codebase for subsequent development or release cycles.

Highlights

  • Version Bump: The project version has been updated from 0.3.2.Beta1-SNAPSHOT to 0.3.3.Beta1-SNAPSHOT across all relevant Maven pom.xml files.
  • Dependency Updates: Dependency versions within the HelloWorldRunner.java example file have been aligned with the new project version.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kabir kabir changed the title Bump 0.3.3 chore: Next is 0.3.3 Nov 4, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the project version to 0.3.3.Beta1-SNAPSHOT across all modules. The changes are consistent and correct for a version bump.

My review includes two suggestions to improve maintainability for future version updates:

  1. In the Maven pom.xml files, I recommend using a property (like ${revision}) to centralize the version number. This is a standard practice in multi-module projects and would mean future version bumps only require changing one line in the root pom.xml.
  2. In the JBang script example, I suggest using a JBang property to define the version, which avoids hardcoding it in multiple dependency declarations.

These changes would make the versioning process simpler and less error-prone.

Comment on lines +2 to +3
//DEPS io.github.a2asdk:a2a-java-sdk-client:0.3.3.Beta1-SNAPSHOT
//DEPS io.github.a2asdk:a2a-java-sdk-client-transport-jsonrpc:0.3.3.Beta1-SNAPSHOT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To avoid hardcoding the version in multiple places and improve maintainability, you could define it as a JBang property and reuse it. This would make future version updates easier and less error-prone.

You can add a properties line at the top of the file (e.g., after the jbang shebang):

//PROPERTIES a2a.version=0.3.3.Beta1-SNAPSHOT

And then reference it in the dependencies:

Suggested change
//DEPS io.github.a2asdk:a2a-java-sdk-client:0.3.3.Beta1-SNAPSHOT
//DEPS io.github.a2asdk:a2a-java-sdk-client-transport-jsonrpc:0.3.3.Beta1-SNAPSHOT
//DEPS io.github.a2asdk:a2a-java-sdk-client:${a2a.version}
//DEPS io.github.a2asdk:a2a-java-sdk-client-transport-jsonrpc:${a2a.version}

<groupId>io.github.a2asdk</groupId>
<artifactId>a2a-java-sdk-parent</artifactId>
<version>0.3.2.Beta1-SNAPSHOT</version>
<version>0.3.3.Beta1-SNAPSHOT</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and simplify future version bumps like this one, consider defining the project version in a property. This centralizes the version number, so it only needs to be changed in one place for the entire project. This is a common practice in multi-module Maven projects.

You could use the built-in ${revision} property.
In this root pom.xml, you would change the version and add a property:

<version>${revision}</version>
...
<properties>
    <revision>0.3.3.Beta1-SNAPSHOT</revision>
    ...
</properties>

Then, in all child pom.xml files, you would update the parent section to use this property:

<parent>
    <groupId>io.github.a2asdk</groupId>
    <artifactId>a2a-java-sdk-parent</artifactId>
    <version>${revision}</version>
    <relativePath>...</relativePath>
</parent>

This would make future version management much easier and less prone to errors.

Suggested change
<version>0.3.3.Beta1-SNAPSHOT</version>
<version>${revision}</version>

@kabir kabir closed this Nov 4, 2025
@kabir kabir deleted the bump-0.3.3 branch November 4, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant