feat: add AgentCard to interceptors parameters#236
feat: add AgentCard to interceptors parameters#236guglielmo-san merged 7 commits intoa2aproject:mainfrom
Conversation
Summary of ChangesHello @guglielmo-san, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the client-side interceptor mechanism to expose the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to add the agentCard to interceptor parameters. The implementation correctly updates the necessary interfaces and the generic executeWithInterceptors method. However, the changes are incomplete as the streaming methods (sendMessageStream and resubscribeTask) have not been updated to pass the agentCard. Additionally, tests have not been updated to validate the new functionality. I've added specific comments with suggestions to address these issues.
Description
This PR add a feature to PR #223 adding the agentCard to the interceptors' parameters. Some values of the agentCard may be necessary at the interceptors level (e.g. security schemes).
BEGIN_COMMIT_OVERRIDE
refactor: add AgentCard to interceptors parameters
END_COMMIT_OVERRIDE