refactor: define a helper function to customize ClientFactoryOptions#240
refactor: define a helper function to customize ClientFactoryOptions#240
Conversation
Summary of ChangesHello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a createFrom helper function to simplify the creation of custom ClientFactoryOptions, which is a great addition for usability. My review focuses on an inconsistency in the merging logic. While top-level arrays like transports are concatenated, nested arrays within clientConfig are replaced, which can be unintuitive and lead to data loss. I've suggested a change to make this behavior consistent. Additionally, I've pointed out that some of the new tests could be more robust. Overall, a good refactoring that will be even better with these adjustments.
# Description
Update `ClientFactory.createFrom` merging logic to work better with
common use-cases:
1. Merge transports by `TransportFactory.protocolName` to allow the
following:
```ts
const factory = new ClientFactory(ClientFactoryOptions.createFrom(ClientFactoryOptions.default, {
transports: [
new JsonRpcTransportFactory({ fetchImpl: myCustomFetch })
]
}))
```
2. Concatenate interceptors to allow providing SDK default interceptors.
3. Other config-like arrays (`preferredTransports`,
`clientConfig.acceptedOutputModes`) are replaced.
Re: follow-up for unreleased #240
2 participants
Description
Deep cloning each object and array for adding an interceptor into default client config (for example) is quite involved, define a helper function so that it can be done as follows: