Spelling/formatting

Author: holtskinner

.github/actions/spelling/allow.txt

@@ -29,12 +29,14 @@ coro
 datamodel
 dunders
 genai
+getkwargs
 gle
 inmemory
 kwarg
 langgraph
 lifecycles
 linting
+lstrips
 oauthoidc
 opensource
 protoc
@@ -43,4 +45,6 @@ pyversions
 socio
 sse
 tagwords
+taskupdate
+testuuid
 vulnz

tests/auth/test_user.py

@@ -10,8 +10,8 @@ def test_is_authenticated_returns_false(self):
 
     def test_user_name_returns_empty_string(self):
         user = UnauthenticatedUser()
-        self.assertEqual(user.user_name, "")
+        self.assertEqual(user.user_name, '')
 
 
-if __name__ == "__main__":
+if __name__ == '__main__':
     unittest.main()

tests/client/test_client.py

@@ -1,29 +1,35 @@
 import unittest
-from unittest.mock import AsyncMock, MagicMock
 
+from unittest.mock import AsyncMock
+
+from a2a.auth.user import UnauthenticatedUser  # Import User types
+from a2a.server.agent_execution.context import (
+    RequestContext,  # Corrected import path
+)
 from a2a.server.agent_execution.simple_request_context_builder import (
     SimpleRequestContextBuilder,
 )
-from a2a.server.agent_execution.context import RequestContext # Corrected import path
+from a2a.server.context import ServerCallContext
 from a2a.server.tasks.task_store import TaskStore
 from a2a.types import (
     Message,
     MessageSendParams,
-    Task,
+    Part,
     # ServerCallContext, # Removed from a2a.types
     Role,
-    Part,
-    TextPart,
-    TaskStatus,
+    Task,
     TaskState,
+    TaskStatus,
+    TextPart,
 )
-from a2a.server.context import ServerCallContext
-from a2a.auth.user import User, UnauthenticatedUser # Import User types
 
 
 # Helper to create a simple message
 def create_sample_message(
-    content="test message", msg_id="msg1", role=Role.user, reference_task_ids=None
+    content='test message',
+    msg_id='msg1',
+    role=Role.user,
+    reference_task_ids=None,
 ):
     return Message(
         messageId=msg_id,
@@ -32,14 +38,18 @@ def create_sample_message(
         referenceTaskIds=reference_task_ids if reference_task_ids else [],
     )
 
+
 # Helper to create a simple task
-def create_sample_task(task_id="task1", status_state=TaskState.submitted, context_id="ctx1"):
+def create_sample_task(
+    task_id='task1', status_state=TaskState.submitted, context_id='ctx1'
+):
     return Task(
         id=task_id,
         contextId=context_id,
         status=TaskStatus(state=status_state),
     )
 
+
 class TestSimpleRequestContextBuilder(unittest.IsolatedAsyncioTestCase):
     def setUp(self):
         self.mock_task_store = AsyncMock(spec=TaskStore)
@@ -61,22 +71,28 @@ def test_init_with_populate_false_task_store_none(self):
     def test_init_with_populate_false_task_store_provided(self):
         # Even if populate is false, task_store might still be provided (though not used by build for related_tasks)
         builder = SimpleRequestContextBuilder(
-            should_populate_referred_tasks=False, task_store=self.mock_task_store
+            should_populate_referred_tasks=False,
+            task_store=self.mock_task_store,
         )
         self.assertFalse(builder._should_populate_referred_tasks)
         self.assertEqual(builder._task_store, self.mock_task_store)
 
     async def test_build_basic_context_no_populate(self):
         builder = SimpleRequestContextBuilder(
-            should_populate_referred_tasks=False, task_store=self.mock_task_store
+            should_populate_referred_tasks=False,
+            task_store=self.mock_task_store,
         )
 
         params = MessageSendParams(message=create_sample_message())
-        task_id = "test_task_id_1"
-        context_id = "test_context_id_1"
-        current_task = create_sample_task(task_id=task_id, context_id=context_id)
+        task_id = 'test_task_id_1'
+        context_id = 'test_context_id_1'
+        current_task = create_sample_task(
+            task_id=task_id, context_id=context_id
+        )
         # Pass a valid User instance, e.g., UnauthenticatedUser or a mock spec'd as User
-        server_call_context = ServerCallContext(user=UnauthenticatedUser(), auth_token="dummy_token")
+        server_call_context = ServerCallContext(
+            user=UnauthenticatedUser(), auth_token='dummy_token'
+        )
 
         request_context = await builder.build(
             params=params,
@@ -92,18 +108,22 @@ async def test_build_basic_context_no_populate(self):
         self.assertEqual(request_context.configuration, params.configuration)
         self.assertEqual(request_context.task_id, task_id)
         self.assertEqual(request_context.context_id, context_id)
-        self.assertEqual(request_context.current_task, current_task) # Property is current_task
-        self.assertEqual(request_context.call_context, server_call_context) # Property is call_context
-        self.assertEqual(request_context.related_tasks, []) # Initialized to []
+        self.assertEqual(
+            request_context.current_task, current_task
+        )  # Property is current_task
+        self.assertEqual(
+            request_context.call_context, server_call_context
+        )  # Property is call_context
+        self.assertEqual(request_context.related_tasks, [])  # Initialized to []
         self.mock_task_store.get.assert_not_called()
 
     async def test_build_populate_true_with_reference_task_ids(self):
         builder = SimpleRequestContextBuilder(
             should_populate_referred_tasks=True, task_store=self.mock_task_store
         )
-        ref_task_id1 = "ref_task1"
-        ref_task_id2 = "ref_task2_missing"
-        ref_task_id3 = "ref_task3"
+        ref_task_id1 = 'ref_task1'
+        ref_task_id2 = 'ref_task2_missing'
+        ref_task_id3 = 'ref_task3'
 
         mock_ref_task1 = create_sample_task(task_id=ref_task_id1)
         mock_ref_task3 = create_sample_task(task_id=ref_task_id3)
@@ -117,15 +137,22 @@ async def get_side_effect(task_id):
             if task_id == ref_task_id3:
                 return mock_ref_task3
             return None
+
         self.mock_task_store.get = AsyncMock(side_effect=get_side_effect)
 
         params = MessageSendParams(
-            message=create_sample_message(reference_task_ids=[ref_task_id1, ref_task_id2, ref_task_id3])
+            message=create_sample_message(
+                reference_task_ids=[ref_task_id1, ref_task_id2, ref_task_id3]
+            )
         )
         server_call_context = ServerCallContext(user=UnauthenticatedUser())
 
         request_context = await builder.build(
-            params=params, task_id="t1", context_id="c1", task=None, context=server_call_context
+            params=params,
+            task_id='t1',
+            context_id='c1',
+            task=None,
+            context=server_call_context,
         )
 
         self.assertEqual(self.mock_task_store.get.call_count, 3)
@@ -134,7 +161,9 @@ async def get_side_effect(task_id):
         self.mock_task_store.get.assert_any_call(ref_task_id3)
 
         self.assertIsNotNone(request_context.related_tasks)
-        self.assertEqual(len(request_context.related_tasks), 2) # Only non-None tasks
+        self.assertEqual(
+            len(request_context.related_tasks), 2
+        )  # Only non-None tasks
         self.assertIn(mock_ref_task1, request_context.related_tasks)
         self.assertIn(mock_ref_task3, request_context.related_tasks)
 
@@ -144,7 +173,11 @@ async def test_build_populate_true_params_none(self):
         )
         server_call_context = ServerCallContext(user=UnauthenticatedUser())
         request_context = await builder.build(
-            params=None, task_id="t1", context_id="c1", task=None, context=server_call_context
+            params=None,
+            task_id='t1',
+            context_id='c1',
+            task=None,
+            context=server_call_context,
         )
         self.assertEqual(request_context.related_tasks, [])
         self.mock_task_store.get.assert_not_called()
@@ -156,64 +189,88 @@ async def test_build_populate_true_reference_ids_empty_or_none(self):
         server_call_context = ServerCallContext(user=UnauthenticatedUser())
 
         # Test with empty list
-        params_empty_refs = MessageSendParams(message=create_sample_message(reference_task_ids=[]))
+        params_empty_refs = MessageSendParams(
+            message=create_sample_message(reference_task_ids=[])
+        )
         request_context_empty = await builder.build(
-            params=params_empty_refs, task_id="t1", context_id="c1", task=None, context=server_call_context
+            params=params_empty_refs,
+            task_id='t1',
+            context_id='c1',
+            task=None,
+            context=server_call_context,
         )
-        self.assertEqual(request_context_empty.related_tasks, []) # Should be [] if list is empty
+        self.assertEqual(
+            request_context_empty.related_tasks, []
+        )  # Should be [] if list is empty
         self.mock_task_store.get.assert_not_called()
 
-        self.mock_task_store.get.reset_mock() # Reset for next call
+        self.mock_task_store.get.reset_mock()  # Reset for next call
 
         # Test with referenceTaskIds=None (Pydantic model might default it to empty list or handle it)
         # create_sample_message defaults to [] if None is passed, so this tests the same as above.
         # To explicitly test None in Message, we'd have to bypass Pydantic default or modify helper.
         # For now, this covers the "no IDs to process" case.
-        msg_with_no_refs = Message(messageId="m2", role=Role.user, parts=[], referenceTaskIds=None)
+        msg_with_no_refs = Message(
+            messageId='m2', role=Role.user, parts=[], referenceTaskIds=None
+        )
         params_none_refs = MessageSendParams(message=msg_with_no_refs)
         request_context_none = await builder.build(
-            params=params_none_refs, task_id="t2", context_id="c2", task=None, context=server_call_context
+            params=params_none_refs,
+            task_id='t2',
+            context_id='c2',
+            task=None,
+            context=server_call_context,
         )
         self.assertEqual(request_context_none.related_tasks, [])
         self.mock_task_store.get.assert_not_called()
 
-
     async def test_build_populate_true_task_store_none(self):
         # This scenario might be prevented by constructor logic if should_populate_referred_tasks is True,
         # but testing defensively. The builder might allow task_store=None if it's set post-init,
         # or if constructor logic changes. Current SimpleRequestContextBuilder takes it at init.
         # If task_store is None, it should not attempt to call get.
         builder = SimpleRequestContextBuilder(
-            should_populate_referred_tasks=True, task_store=None # Explicitly None
+            should_populate_referred_tasks=True,
+            task_store=None,  # Explicitly None
         )
         params = MessageSendParams(
-            message=create_sample_message(reference_task_ids=["ref1"])
+            message=create_sample_message(reference_task_ids=['ref1'])
         )
         server_call_context = ServerCallContext(user=UnauthenticatedUser())
 
         request_context = await builder.build(
-            params=params, task_id="t1", context_id="c1", task=None, context=server_call_context
+            params=params,
+            task_id='t1',
+            context_id='c1',
+            task=None,
+            context=server_call_context,
         )
         # Expect related_tasks to be an empty list as task_store is None
         self.assertEqual(request_context.related_tasks, [])
         # No mock_task_store to check calls on, this test is mostly for graceful handling.
 
-
     async def test_build_populate_false_with_reference_task_ids(self):
         builder = SimpleRequestContextBuilder(
-            should_populate_referred_tasks=False, task_store=self.mock_task_store
+            should_populate_referred_tasks=False,
+            task_store=self.mock_task_store,
         )
         params = MessageSendParams(
-            message=create_sample_message(reference_task_ids=["ref_task_should_not_be_fetched"])
+            message=create_sample_message(
+                reference_task_ids=['ref_task_should_not_be_fetched']
+            )
         )
         server_call_context = ServerCallContext(user=UnauthenticatedUser())
 
         request_context = await builder.build(
-            params=params, task_id="t1", context_id="c1", task=None, context=server_call_context
+            params=params,
+            task_id='t1',
+            context_id='c1',
+            task=None,
+            context=server_call_context,
         )
         self.assertEqual(request_context.related_tasks, [])
         self.mock_task_store.get.assert_not_called()
 
 
-if __name__ == "__main__":
+if __name__ == '__main__':
     unittest.main()