Skip to content

fix: remove unnecessary hasattr checks #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kthota-g merged 2 commits into from
Jun 2, 2025
Merged

fix: remove unnecessary hasattr checks #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26c72b
fix/remove-unnecessary-hasattr-checks
dharmveerjakhar Jun 2, 2025
a499f03
Merge branch 'main' into main
holtskinner Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/a2a/server/apps/starlette_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def _generate_error_response(
log_level,
f'Request Error (ID: {request_id}): '
f"Code={error_resp.error.code}, Message='{error_resp.error.message}'"
f'{", Data=" + str(error_resp.error.data) if hasattr(error, "data") and error_resp.error.data else ""}',
f'{", Data=" + str(error_resp.error.data) if error_resp.error.data else ""}',
)
return JSONResponse(
error_resp.model_dump(mode='json', exclude_none=True),
Expand Down
2 changes: 1 addition & 1 deletion src/a2a/utils/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def append_artifact_to_task(task: Task, event: TaskArtifactUpdateEvent) -> None:

# Find existing artifact by its id
for i, art in enumerate(task.artifacts):
if hasattr(art, 'artifactId') and art.artifactId == artifact_id:
if art.artifactId == artifact_id:
existing_artifact = art
existing_artifact_list_index = i
break
Expand Down