Skip to content

style: format code using ruff fix and format#196

Merged
holtskinner merged 1 commit intoa2aproject:mainfrom
ognis1205:chore/lint
Jun 16, 2025
Merged

style: format code using ruff fix and format#196
holtskinner merged 1 commit intoa2aproject:mainfrom
ognis1205:chore/lint

Conversation

@ognis1205
Copy link
Contributor

@ognis1205 ognis1205 commented Jun 14, 2025

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format)
  • Appropriate docs were updated (if necessary)

Formatting Notice

It seemed that some files were not properly formatted by nox -s format, so I manually ran the formatting steps defined in noxfile.py:

  • uv run no_implicit_optional --use-union-or .
  • uv run ruff check --fix-only --config .github/linters/.ruff.toml .
  • uv run ruff format --config .github/linters/.ruff.toml .

I did not run:

  • uv run autoflake -i -r --remove-all-unused-imports .

but I have confirmed there are no changes needed except for gRPC-generated sources, which are intentionally excluded.

Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
@ognis1205 ognis1205 requested a review from a team as a code owner June 14, 2025 12:16
@ognis1205 ognis1205 requested a review from pwwpche June 14, 2025 12:16
@ognis1205 ognis1205 changed the title style: auto-format code using ruff fix and format style: format code using ruff fix and format Jun 14, 2025
@holtskinner holtskinner merged commit c983481 into a2aproject:main Jun 16, 2025
6 checks passed
@ognis1205 ognis1205 deleted the chore/lint branch June 16, 2025 16:52
holtskinner pushed a commit that referenced this pull request Jun 24, 2025
# Description

### Formatting Notice

It seemed that some files were not properly formatted by `nox -s
format`, so I manually ran the formatting steps defined in `noxfile.py`:

- `uv run no_implicit_optional --use-union-or .`  
- `uv run ruff check --fix-only --config .github/linters/.ruff.toml .`  
- `uv run ruff format --config .github/linters/.ruff.toml .`

I **did not run**:

- `uv run autoflake -i -r --remove-all-unused-imports .`

but I have **confirmed there are no changes needed except for
gRPC-generated sources**, which are intentionally excluded.

Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
holtskinner pushed a commit that referenced this pull request Jun 30, 2025
It seemed that some files were not properly formatted by `nox -s
format`, so I manually ran the formatting steps defined in `noxfile.py`:

- `uv run no_implicit_optional --use-union-or .`
- `uv run ruff check --fix-only --config .github/linters/.ruff.toml .`
- `uv run ruff format --config .github/linters/.ruff.toml .`

I **did not run**:

- `uv run autoflake -i -r --remove-all-unused-imports .`

but I have **confirmed there are no changes needed except for
gRPC-generated sources**, which are intentionally excluded.

Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants