fix: Add validation for empty artifact lists in completed_task
#308
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @pankaj-bind, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the robustness of the completed_task function by introducing explicit validation for the artifacts parameter. This change prevents the function from processing invalid or empty artifact lists, thereby improving data integrity and overall system stability. Accompanying tests ensure the new validation behaves as expected.
Highlights
- Validation Enhancement: The
completed_taskfunction ina2a/utils/task.pynow includes a validation check for itsartifactsparameter. This ensures that the providedartifactslist is not empty and contains onlyArtifactobjects. - Error Handling: A
ValueErroris now raised bycompleted_taskif theartifactslist is empty or contains items that are not instances ofArtifact, preventing unexpected behavior from invalid inputs. - Test Coverage: New unit tests have been added to
tests/utils/test_task.pyspecifically to verify the new validation logic. These tests cover scenarios where an emptyartifactslist or a list with invalid item types is passed tocompleted_task, ensuring theValueErroris correctly raised.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces validation for the artifacts list in the completed_task function, enhancing the robustness of the code. The tests adequately cover the new validation logic, and I've suggested making the error messages more specific to improve debuggability.
holtskinner
changed the title
holtskinner
changed the title
completed_task
🤖 I have created a release *beep* *boop* --- ## [0.2.13](v0.2.12...v0.2.13) (2025-07-17) ### Features * Add `get_data_parts()` and `get_file_parts()` helper methods ([#312](#312)) ([5b98c32](5b98c32)) * Support for Database based Push Config Store ([#299](#299)) ([e5d99ee](e5d99ee)) * Update A2A types from specification 🤖 ([#319](#319)) ([18506a4](18506a4)) ### Bug Fixes * Add Input Validation for Task IDs in TaskManager ([#310](#310)) ([a38d438](a38d438)) * Add validation for empty artifact lists in `completed_task` ([#308](#308)) ([c4a324d](c4a324d)) * Handle readtimeout errors. ([#305](#305)) ([b94b8f5](b94b8f5)), closes [#249](#249) ### Documentation * Update Documentation Site Link ([#315](#315)) ([edf392c](edf392c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
2 participants
This update addresses an issue where the
completed_taskfunction ina2a/utils/task.pydid not perform any validation on theartifactslist. This could lead to unexpected behavior if an empty or invalid list was provided.This change introduces a validation check to ensure that the
artifactslist is a non-empty list ofArtifactobjects, raising aValueErrorif the validation fails.Changes:
a2a/utils/task.pyto add a validation check for theartifactsparameter in thecompleted_taskfunction.tests/utils/test_task.pyto include tests for the new validation logic, covering cases with empty lists and lists containing invalid items.