Skip to content

Conversation

@pankaj-bind
Copy link
Contributor

Description

Adding input validation to the new_task function in a2a/utils/task.py. The new validation checks if any part within a Message contains empty content (e.g., TextPart(text='')) and raises a ValueError if it does.

This enhancement improves the system's reliability by preventing the creation and processing of tasks with invalid or incomplete message data.

Changes Made

  • Updated the new_task function in src/a2a/utils/task.py to iterate through message parts and check for empty content.
  • Added a new test case, test_new_task_invalid_message_empty_content, in tests/utils/test_task.py to ensure the validation works as expected.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @pankaj-bind, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the reliability of task creation by introducing validation to ensure that messages do not contain empty content parts. This prevents incomplete or invalid data from entering the system, improving overall data integrity.

Highlights

  • Input Validation: Implemented new input validation within the new_task function in src/a2a/utils/task.py to prevent the creation of tasks with Message parts that contain empty content (specifically TextPart instances with empty text). This check iterates through all message parts and raises a ValueError if invalid content is found.
  • Test Coverage: Added a new unit test, test_new_task_invalid_message_empty_content, to tests/utils/test_task.py. This test verifies that the new_task function correctly raises a ValueError when provided with a Message containing an empty TextPart.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The code changes introduce input validation for empty message content, specifically targeting TextPart. To enhance robustness, consider extending the validation to other part types like FilePart.

pankaj-bind and others added 2 commits July 20, 2025 16:36
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@holtskinner holtskinner changed the title feat: Add Input Validation for Empty Message Content fix: Add Input Validation for Empty Message Content Jul 21, 2025
@holtskinner holtskinner merged commit 5061834 into a2aproject:main Jul 21, 2025
5 checks passed
holtskinner pushed a commit that referenced this pull request Jul 21, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.2.15](v0.2.14...v0.2.15)
(2025-07-21)


### Bug Fixes

* Add Input Validation for Empty Message Content
([#327](#327))
([5061834](5061834))
* Prevent import grpc issues for Client after making dependencies
optional ([#330](#330))
([53ad485](53ad485)),
closes [#326](#326)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants