-
Notifications
You must be signed in to change notification settings - Fork 325
fix: Add Input Validation for Empty Message Content #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add Input Validation for Empty Message Content #327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @pankaj-bind, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the reliability of task creation by introducing validation to ensure that messages do not contain empty content parts. This prevents incomplete or invalid data from entering the system, improving overall data integrity.
Highlights
- Input Validation: Implemented new input validation within the
new_taskfunction insrc/a2a/utils/task.pyto prevent the creation of tasks withMessageparts that contain empty content (specificallyTextPartinstances with emptytext). This check iterates through all message parts and raises aValueErrorif invalid content is found. - Test Coverage: Added a new unit test,
test_new_task_invalid_message_empty_content, totests/utils/test_task.py. This test verifies that thenew_taskfunction correctly raises aValueErrorwhen provided with aMessagecontaining an emptyTextPart.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The code changes introduce input validation for empty message content, specifically targeting TextPart. To enhance robustness, consider extending the validation to other part types like FilePart.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.2.15](v0.2.14...v0.2.15) (2025-07-21) ### Bug Fixes * Add Input Validation for Empty Message Content ([#327](#327)) ([5061834](5061834)) * Prevent import grpc issues for Client after making dependencies optional ([#330](#330)) ([53ad485](53ad485)), closes [#326](#326) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Description
Adding input validation to the
new_taskfunction ina2a/utils/task.py. The new validation checks if anypartwithin aMessagecontains empty content (e.g.,TextPart(text='')) and raises aValueErrorif it does.This enhancement improves the system's reliability by preventing the creation and processing of tasks with invalid or incomplete message data.
Changes Made
new_taskfunction insrc/a2a/utils/task.pyto iterate through message parts and check for empty content.test_new_task_invalid_message_empty_content, intests/utils/test_task.pyto ensure the validation works as expected.