-
Notifications
You must be signed in to change notification settings - Fork 325
feat(spec): Update A2A types from specification 🤖 #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spec): Update A2A types from specification 🤖 #346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, automatically generated by a2a-bot, updates the A2A Python types in src/a2a/types.py to align with the latest A2A specification. The primary focus of these changes is to enhance the definition and validation of URLs and transport protocols within the A2A models, providing clearer guidance and more robust data structures for agent interfaces.
Highlights
- Type Enhancements for URLs: The
urlfields within theAgentInterfaceandAgentCardmodels have been upgraded fromstrtopydantic.AnyUrl. This change introduces robust URL validation and improves type safety, ensuring that all URLs conform to a valid format. - Formalized Transport Protocols: A new
TransportProtocolEnum has been introduced. This enum explicitly defines the core supported A2A transport protocols (JSONRPC,GRPC,HTTP+JSON), enhancing clarity, consistency, and maintainability when referencing these protocols. - Improved Agent Interface and Card Definitions: The
AgentInterfaceandAgentCardmodels have received significant updates to their docstrings, including new examples and best practices. These enhancements clarify how agents should expose their interfaces and how clients should interpret and utilize thetransport,url,additional_interfaces, andpreferred_transportfields.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the A2A type definitions, incorporating pydantic.AnyUrl for URL validation and improving documentation. I suggest using the TransportProtocol enum to enhance type safety and consistency across the models.
| """ | ||
|
|
||
| transport: str | ||
| transport: str = Field(..., examples=['JSONRPC', 'GRPC', 'HTTP+JSON']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using the TransportProtocol enum for the transport field instead of str to improve type safety and code clarity. This ensures only valid transport protocols are used, enhancing maintainability.
| transport: str = Field(..., examples=['JSONRPC', 'GRPC', 'HTTP+JSON']) | |
| transport: TransportProtocol = Field(..., examples=[TransportProtocol.jsonrpc, TransportProtocol.grpc, TransportProtocol.http_json]) |
| preferred_transport: str | None = Field( | ||
| default='JSONRPC', examples=['JSONRPC', 'GRPC', 'HTTP+JSON'] | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leverage the TransportProtocol enum for preferred_transport to improve type safety. Using TransportProtocol.jsonrpc as the default value enhances explicitness and consistency.
| preferred_transport: str | None = Field( | |
| default='JSONRPC', examples=['JSONRPC', 'GRPC', 'HTTP+JSON'] | |
| ) | |
| preferred_transport: TransportProtocol | None = Field( | |
| default=TransportProtocol.jsonrpc, examples=[TransportProtocol.jsonrpc, TransportProtocol.grpc, TransportProtocol.http_json] | |
| ) |
…352298e8b19737dd5a
This PR updates
src/a2a/types.pybased on the latestspecification/json/a2a.jsonfrom a2aproject/A2A.