Skip to content

Conversation

@a2a-bot
Copy link
Collaborator

@a2a-bot a2a-bot commented Jul 24, 2025

This PR updates src/a2a/types.py based on the latest specification/json/a2a.json from a2aproject/A2A.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by a2a-bot, updates the A2A Python types in src/a2a/types.py to align with the latest A2A specification. The primary focus of these changes is to enhance the definition and validation of URLs and transport protocols within the A2A models, providing clearer guidance and more robust data structures for agent interfaces.

Highlights

  • Type Enhancements for URLs: The url fields within the AgentInterface and AgentCard models have been upgraded from str to pydantic.AnyUrl. This change introduces robust URL validation and improves type safety, ensuring that all URLs conform to a valid format.
  • Formalized Transport Protocols: A new TransportProtocol Enum has been introduced. This enum explicitly defines the core supported A2A transport protocols (JSONRPC, GRPC, HTTP+JSON), enhancing clarity, consistency, and maintainability when referencing these protocols.
  • Improved Agent Interface and Card Definitions: The AgentInterface and AgentCard models have received significant updates to their docstrings, including new examples and best practices. These enhancements clarify how agents should expose their interfaces and how clients should interpret and utilize the transport, url, additional_interfaces, and preferred_transport fields.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the A2A type definitions, incorporating pydantic.AnyUrl for URL validation and improving documentation. I suggest using the TransportProtocol enum to enhance type safety and consistency across the models.

"""

transport: str
transport: str = Field(..., examples=['JSONRPC', 'GRPC', 'HTTP+JSON'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using the TransportProtocol enum for the transport field instead of str to improve type safety and code clarity. This ensures only valid transport protocols are used, enhancing maintainability.

Suggested change
transport: str = Field(..., examples=['JSONRPC', 'GRPC', 'HTTP+JSON'])
transport: TransportProtocol = Field(..., examples=[TransportProtocol.jsonrpc, TransportProtocol.grpc, TransportProtocol.http_json])

Comment on lines +1679 to +1681
preferred_transport: str | None = Field(
default='JSONRPC', examples=['JSONRPC', 'GRPC', 'HTTP+JSON']
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Leverage the TransportProtocol enum for preferred_transport to improve type safety. Using TransportProtocol.jsonrpc as the default value enhances explicitness and consistency.

Suggested change
preferred_transport: str | None = Field(
default='JSONRPC', examples=['JSONRPC', 'GRPC', 'HTTP+JSON']
)
preferred_transport: TransportProtocol | None = Field(
default=TransportProtocol.jsonrpc, examples=[TransportProtocol.jsonrpc, TransportProtocol.grpc, TransportProtocol.http_json]
)

holtskinner added a commit to a2aproject/A2A that referenced this pull request Jul 24, 2025
holtskinner added a commit to a2aproject/A2A that referenced this pull request Jul 24, 2025
@holtskinner holtskinner deleted the auto-update-a2a-types-e834347c279186d9d7873b352298e8b19737dd5a branch July 24, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants