feat!: Add method for fetching extended card#359
Conversation
# Description
This change adds support for a new JSON-RPC method `agent/getAuthenticatedExtendedCard` for fetching authenticated extended card.
This is only applicable if `AgentCard.supportsAuthenticatedExtendedCard` bit is set to `true` that allows fetching authenticated context specific agent card.
In the previous versions, the extended card was served via `{AgentCard.url}/../agent/authenticatedExtendedCard` endpoint. This endpoint is being removed in favor of the JSON-RPC method. This endpoint will be deprecated in the SDKs and will be removed in a future release.
Release-As: 0.3.0
There was a problem hiding this comment.
Summary of Changes
Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on migrating the mechanism for fetching authenticated extended card information from an existing HTTP endpoint to a new, dedicated JSON-RPC method. This change aims to standardize the API's interaction patterns, improve clarity in data exchange, and enhance error handling by introducing specific data models and error types for the new JSON-RPC flow.
Highlights
- New JSON-RPC Method: I've introduced a new JSON-RPC method,
agent/getAuthenticatedExtendedCard, to facilitate fetching authenticated extended card data. This new method is designed to replace an existing HTTP endpoint, streamlining the API's approach to this functionality. - New Data Models: I've added several new Pydantic models, including
GetAuthenticatedExtendedCardRequest,GetAuthenticatedExtendedCardSuccessResponse, andGetAuthenticatedExtendedCardResponse, to precisely define the structure for the new JSON-RPC request and its corresponding successful and overall responses. - Enhanced Error Handling: I've implemented a specific error type,
AuthenticatedExtendedCardNotConfiguredError, to provide clear and standardized feedback when an authenticated extended card is not configured for an agent, improving the API's error reporting. - API Schema Integration: I've updated the core A2A JSON-RPC unions (
A2ARequest,JSONRPCResponse,A2AError,JSONRPCErrorResponse) to seamlessly incorporate the newly defined request, response, and error types, ensuring the API schema remains consistent and up-to-date.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces the necessary Pydantic types for a new agent/getAuthenticatedExtendedCard JSON-RPC method. The changes are well-structured and align with the existing patterns in the codebase. I've made one suggestion to improve documentation consistency.
Description
This change adds support for a new JSON-RPC method
agent/getAuthenticatedExtendedCardfor fetching authenticated extended card.This is only applicable if
AgentCard.supportsAuthenticatedExtendedCardbit is set totruethat allows fetching authenticated context specific agent card.In the previous versions, the extended card was served via
{AgentCard.url}/../agent/authenticatedExtendedCardendpoint. This endpoint is being removed in favor of the JSON-RPC method. This endpoint will be deprecated in the SDKs and will be removed in a future release.Release-As: 0.3.0