Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the a2a.types module, which contains the Python data models for the A2A specification. The changes reflect an evolution of the specification, primarily focusing on enhancing data validation through stricter type annotations and minimum length constraints for lists, introducing a new API method for authenticated extended agent cards, and improving versioning clarity.
Highlights
- Specification Update: The
src/a2a/types.pyfile, which is code-generated from a specification, has been manually updated to reflect changes in the underlying A2A specification, including a change in the source branch used for generation. - Improved Data Validation: Numerous string fields representing URLs have been updated to
pydantic.AnyUrlfor stricter validation, ensuring that these fields contain valid URL formats. Additionally, several list fields now enforce amin_lengthof 1, preventing empty lists where content is expected. - New JSON-RPC Method: A new JSON-RPC method,
agent/getAuthenticatedExtendedCard, has been introduced. This includes the definition of its corresponding request, a new success response type (GetAuthenticatedExtendedCardSuccessResponse), and a new specific error type (AuthenticatedExtendedCardNotConfiguredError). - Semantic Versioning Enforcement: The
AgentCard.versionfield now includes a regex pattern constraint, enforcing adherence to Semantic Versioning for agent versions. - Type Refinements: The
TaskStatus.timestampfield has been updated from a genericstrtodatetimefor more accurate and robust date/time handling.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the Pydantic models in src/a2a/types.py by regenerating them from an updated specification. The changes introduce stricter validation by using AnyUrl and datetime types, enforcing non-empty lists with min_length=1, and adding a regex pattern for semantic versioning.
A new JSON-RPC method agent/getAuthenticatedExtendedCard is also defined, but the server-side implementation appears to be missing.
| | TaskResubscriptionRequest | ||
| | ListTaskPushNotificationConfigRequest | ||
| | DeleteTaskPushNotificationConfigRequest | ||
| | GetAuthenticatedExtendedCardRequest |
There was a problem hiding this comment.
This change adds GetAuthenticatedExtendedCardRequest to the A2ARequest discriminated union. It seems the corresponding server-side logic to handle this new request type is missing. Without a handler, any request of this new type will result in an UnsupportedOperationError.
Please ensure that the server-side implementation is added, or clarify if it's intended for a future PR.
bfc7401 to
d4f583a
Compare
d4f583a to
0ab21b9
Compare
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.bash scripts/format.shfrom the repository root to format)Fixes #<issue_number_goes_here> 🦕