fix(proto): Add icon_url to a2a.proto#416
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the A2A gRPC specification, primarily by introducing an 'icon_url' field to the 'AgentCard' message. It also refines the initialization parameters for several message types, making certain boolean fields optional, and corrects a minor path in a service definition. These changes are reflected in the generated Python protobuf files.
Highlights
- New Field Addition: A new 'icon_url' field has been added to the 'AgentCard' message, allowing for the specification of an icon URL for agents.
- Constructor Parameter Refinements: Several boolean fields, including 'blocking' in 'SendMessageConfiguration', 'final' in 'TaskStatusUpdateEvent', and 'append'/'last_chunk' in 'TaskArtifactUpdateEvent', have been made optional in their respective message constructors.
- API Path Correction: The API path for the 'CreateTaskPushNotificationConfig' service has been corrected, changing the segment from 'task' to 'tasks' for consistency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request appears to be an automated update to the gRPC Python files, reflecting changes in the underlying Protobuf specification. The main changes include the addition of a new icon_url field to the AgentCard message and systematic updates to the type hints in the a2a_pb2.pyi stub file. Several boolean fields in __init__ methods are now correctly typed as Optional[bool], which more accurately reflects their optional nature in Protobuf messages and improves type safety. The changes are consistent across the generated files and appear to be correct. I have not identified any issues or bugs in this update.
holtskinner
changed the title
holtskinner
changed the title
icon_url to a2a.proto
holtskinner
force-pushed
the
auto-update-a2a-types-17e7f62df9a3e4ca0768ab8d4f0bb7573b3d73e1
branch
from
de0d3ed to
878f9c3
Compare
holtskinner
deleted the
auto-update-a2a-types-17e7f62df9a3e4ca0768ab8d4f0bb7573b3d73e1
branch
🤖 I have created a release *beep* *boop* --- ## [0.3.2](v0.3.1...v0.3.2) (2025-08-20) ### Bug Fixes * Add missing mime_type and name in proto conversion utils ([#408](#408)) ([72b2ee7](72b2ee7)) * Add name field to FilePart protobuf message ([#403](#403)) ([1dbe33d](1dbe33d)) * Client hangs when implementing `AgentExecutor` and `await`ing twice in execute method ([#379](#379)) ([c147a83](c147a83)) * **grpc:** Update `CreateTaskPushNotificationConfig` endpoint to `/v1/{parent=tasks/*/pushNotificationConfigs}` ([#415](#415)) ([73dddc3](73dddc3)) * make `event_consumer` tolerant to closed queues on py3.13 ([#407](#407)) ([a371461](a371461)) * non-blocking `send_message` server handler not invoke push notification ([#394](#394)) ([db82a65](db82a65)) * **proto:** Add `icon_url` to `a2a.proto` ([#416](#416)) ([00703e3](00703e3)) * **spec:** Suggest Unique Identifier fields to be UUID ([#405](#405)) ([da14cea](da14cea)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
2 participants
Commit: a2aproject/A2A@17e7f62