chore(gRPC): Update a2a.proto to include metadata on GetTaskRequest#417
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the A2A service specification, primarily by introducing a new metadata field to the GetTaskRequest message. This enhancement allows clients to send additional, unstructured data when requesting task information. The changes are reflected in the regenerated Python protobuf and type stub files, ensuring that the client-side code aligns with the updated API definition.
Highlights
- Enhanced GetTaskRequest with Metadata: The
GetTaskRequestmessage now includes an optionalmetadatafield. This field is of typegoogle.protobuf.Struct, allowing for flexible, unstructured key-value data to be associated with task retrieval requests. - Automated Protobuf Code Regeneration: The Python protobuf and type stub files (
a2a_pb2.pyanda2a_pb2.pyi) have been automatically regenerated to reflect the latest specification changes, ensuring API consistency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates generated gRPC files to add a metadata field to the GetTaskRequest message, based on a specification update.
However, the PR is critically incomplete as it only contains the generated files. The application logic that consumes GetTaskRequest has not been updated to handle the new metadata field. This includes GrpcHandler.GetTask in src/a2a/server/request_handlers/grpc_handler.py and its related tests in tests/server/request_handlers/test_grpc_handler.py.
Please update the relevant application and test code to fully implement and validate this change. Without these updates, the new field has no effect and the code is out of sync with its data definitions.
a2a.proto to include metadata on GetTaskRequest
Commit: a2aproject/A2A@f0d48cd