-
Notifications
You must be signed in to change notification settings - Fork 8
Added an option to vertically align marquee items #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/marquee-block-timeline
Are you sure you want to change the base?
Added an option to vertically align marquee items #105
Conversation
pixel21
commented
Sep 29, 2025
- The fade should inherit background color of the block now
- The fade should inherit background color of the block now
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
nickpagz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well and I think we can merge this as-is unless my nitpick comment is an easy fix. If not we can add that as a separate issue to track, or decide not to fix it.
| } | ||
|
|
||
| &::before { | ||
| background: inherit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: I wonder if there's a way to fade this differently so we can pickup parent block backgrounds? I'm not sure it is, but might be worth exploring. More specifically, if I don't set a background color for the block, but the parent block (like a group block) or the page has a background color set, the fade is still from white to transparent (see screenshot).
The work-around here is to set the marquee block bg to match the page/parent bg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.