Fix plugin not loading in headless mode if JavaFX is unavailable#7
Closed
leMaik wants to merge 2 commits intoaTom3333:masterfrom
Closed
Fix plugin not loading in headless mode if JavaFX is unavailable#7leMaik wants to merge 2 commits intoaTom3333:masterfrom
leMaik wants to merge 2 commits intoaTom3333:masterfrom
Conversation
leMaik
changed the title
Contributor
Author
|
Turns out that this bug is entirely caused by a bug in Chunky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once chunky-dev/chunky#1820 is merged, this change will make this plugin load properly in headless mode.
Tried it by rendering a scene that uses the small leaf octree in a
eclipse-temurin:21container, which would not load the plugin before.This change is completely backward-compatible. Older Chunky versions will continue to load the UI variant of the plugin and fail to load the plugin in headless mode.
Fixes #6