Skip to content

Commit 5e40274

Browse files
committed
minor symfony#24473 [DX][FrameworkBundle] Clarify where to find exceptions for non-registered commands (sroze)
This PR was merged into the 3.4 branch. Discussion ---------- [DX][FrameworkBundle] Clarify where to find exceptions for non-registered commands | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | ø As a developer, when I saw "Some commands could not be registered." displayed on my console... it wasn't clear ether the next displayed exception was related to this or not. Just adding a reference to the "following errors" would help. Commits ------- 427212d Clarify the exceptions are going to be rendered just after
2 parents e7c3456 + 427212d commit 5e40274

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/Symfony/Bundle/FrameworkBundle/Console/Application.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ private function renderRegistrationErrors(InputInterface $input, OutputInterface
190190
$output = $output->getErrorOutput();
191191
}
192192

193-
(new SymfonyStyle($input, $output))->warning('Some commands could not be registered.');
193+
(new SymfonyStyle($input, $output))->warning('Some commands could not be registered:');
194194

195195
foreach ($this->registrationErrors as $error) {
196196
$this->doRenderException($error, $output);

src/Symfony/Bundle/FrameworkBundle/Tests/Console/ApplicationTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ public function testRunOnlyWarnsOnUnregistrableCommand()
160160
$output = $tester->getDisplay();
161161

162162
$this->assertSame(0, $tester->getStatusCode());
163-
$this->assertContains('Some commands could not be registered.', $output);
163+
$this->assertContains('Some commands could not be registered:', $output);
164164
$this->assertContains('throwing', $output);
165165
$this->assertContains('fine', $output);
166166
}

0 commit comments

Comments
 (0)