minor symfony#14123 CS: Use "self" keyword instead of class name if possible (gharlan)

This PR was merged into the 2.3 branch.

Discussion
----------

CS: Use "self" keyword instead of class name if possible

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Fixes provided by new fixer: PHP-CS-Fixer/PHP-CS-Fixer#1116

If this pr is merged I would change the level of the fixer to `symfony`.

Commits
-------

e72128f CS: Use "self" keyword instead of class name if possible

Author: nicolas-grekas

src/Symfony/Component/Config/Definition/Builder/ExprBuilder.php

@@ -224,7 +224,7 @@ public function end()
     public static function buildExpressions(array $expressions)
     {
         foreach ($expressions as $k => $expr) {
-            if ($expr instanceof ExprBuilder) {
+            if ($expr instanceof self) {
                 $if = $expr->ifPart;
                 $then = $expr->thenPart;
                 $expressions[$k] = function ($v) use ($if, $then) {

src/Symfony/Component/Config/Loader/FileLoader.php

@@ -82,7 +82,7 @@ public function import($resource, $type = null, $ignoreErrors = false, $sourceRe
         try {
             $loader = $this->resolve($resource, $type);
 
-            if ($loader instanceof FileLoader && null !== $this->currentDir) {
+            if ($loader instanceof self && null !== $this->currentDir) {
                 // we fallback to the current locator to keep BC
                 // as some some loaders do not call the parent __construct()
                 // @deprecated should be removed in 3.0

src/Symfony/Component/HttpFoundation/File/File.php

@@ -139,7 +139,7 @@ protected function getTargetFile($directory, $name = null)
 
         $target = rtrim($directory, '/\\').DIRECTORY_SEPARATOR.(null === $name ? $this->getBasename() : $this->getName($name));
 
-        return new File($target, false);
+        return new self($target, false);
     }
 
     /**

src/Symfony/Component/Intl/Intl.php

@@ -117,7 +117,7 @@ public static function getCurrencyBundle()
     {
         if (null === self::$currencyBundle) {
             self::$currencyBundle = new CurrencyBundle(
-                self::getDataDirectory().'/'.Intl::CURRENCY_DIR,
+                self::getDataDirectory().'/'.self::CURRENCY_DIR,
                 self::getEntryReader(),
                 self::getLocaleBundle()
             );
@@ -135,11 +135,11 @@ public static function getLanguageBundle()
     {
         if (null === self::$languageBundle) {
             self::$languageBundle = new LanguageBundle(
-                self::getDataDirectory().'/'.Intl::LANGUAGE_DIR,
+                self::getDataDirectory().'/'.self::LANGUAGE_DIR,
                 self::getEntryReader(),
                 self::getLocaleBundle(),
                 new ScriptDataProvider(
-                    self::getDataDirectory().'/'.Intl::SCRIPT_DIR,
+                    self::getDataDirectory().'/'.self::SCRIPT_DIR,
                     self::getEntryReader()
                 )
             );
@@ -157,7 +157,7 @@ public static function getLocaleBundle()
     {
         if (null === self::$localeBundle) {
             self::$localeBundle = new LocaleBundle(
-                self::getDataDirectory().'/'.Intl::LOCALE_DIR,
+                self::getDataDirectory().'/'.self::LOCALE_DIR,
                 self::getEntryReader()
             );
         }
@@ -174,7 +174,7 @@ public static function getRegionBundle()
     {
         if (null === self::$regionBundle) {
             self::$regionBundle = new RegionBundle(
-                self::getDataDirectory().'/'.Intl::REGION_DIR,
+                self::getDataDirectory().'/'.self::REGION_DIR,
                 self::getEntryReader(),
                 self::getLocaleBundle()
             );

src/Symfony/Component/PropertyAccess/PropertyPath.php

@@ -76,7 +76,7 @@ class PropertyPath implements \IteratorAggregate, PropertyPathInterface
     public function __construct($propertyPath)
     {
         // Can be used as copy constructor
-        if ($propertyPath instanceof PropertyPath) {
+        if ($propertyPath instanceof self) {
             /* @var PropertyPath $propertyPath */
             $this->elements = $propertyPath->elements;
             $this->singulars = $propertyPath->singulars;

src/Symfony/Component/Routing/Matcher/Dumper/DumperCollection.php

@@ -50,7 +50,7 @@ public function all()
      */
     public function add($child)
     {
-        if ($child instanceof DumperCollection) {
+        if ($child instanceof self) {
             $child->setParent($this);
         }
         $this->children[] = $child;
@@ -64,7 +64,7 @@ public function add($child)
     public function setAll(array $children)
     {
         foreach ($children as $child) {
-            if ($child instanceof DumperCollection) {
+            if ($child instanceof self) {
                 $child->setParent($this);
             }
         }

src/Symfony/Component/Routing/Matcher/Dumper/DumperPrefixCollection.php

@@ -66,7 +66,7 @@ public function addPrefixRoute(DumperRoute $route)
 
             // Prefix starts with route's prefix
             if ('' === $collection->prefix || 0 === strpos($prefix, $collection->prefix)) {
-                $child = new DumperPrefixCollection();
+                $child = new self();
                 $child->setPrefix(substr($prefix, 0, strlen($collection->prefix) + 1));
                 $collection->add($child);
 

src/Symfony/Component/Security/Acl/Domain/RoleSecurityIdentity.php

@@ -52,7 +52,7 @@ public function getRole()
      */
     public function equals(SecurityIdentityInterface $sid)
     {
-        if (!$sid instanceof RoleSecurityIdentity) {
+        if (!$sid instanceof self) {
             return false;
         }
 

src/Symfony/Component/Security/Acl/Domain/UserSecurityIdentity.php

@@ -102,7 +102,7 @@ public function getClass()
      */
     public function equals(SecurityIdentityInterface $sid)
     {
-        if (!$sid instanceof UserSecurityIdentity) {
+        if (!$sid instanceof self) {
             return false;
         }
 

src/Symfony/Component/Validator/Constraint.php

@@ -154,7 +154,7 @@ public function __set($option, $value)
      */
     public function addImplicitGroupName($group)
     {
-        if (in_array(Constraint::DEFAULT_GROUP, $this->groups) && !in_array($group, $this->groups)) {
+        if (in_array(self::DEFAULT_GROUP, $this->groups) && !in_array($group, $this->groups)) {
             $this->groups[] = $group;
         }
     }