MinimumSubarrayWithTarget #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create Longest Substring Without Repeating Characters
Code of Longest Substring Without Repeating Characters
| int n=vect.size(); | ||
| int target=14; | ||
| int minlen=INT_MAX; | ||
| int ans = MinimumSubarrayWithTarget(vect,target,minlen); |
There was a problem hiding this comment.
Don't pass anything in the function other than arr and target. Declare everything in the function itself and not in the main method.
| #include<bits/stdc++.h> | ||
| using namespace std; | ||
|
|
||
| int MinimumSubarrayWithTarget(vector<int>vect,int target,int minlen) { |
|
|
||
| int windowStart = 0; | ||
| int windowSum = 0; | ||
| for(int windowEnd = 0; windowEnd < vect.size(); windowEnd++) { |
There was a problem hiding this comment.
Call the array as arr or nums not vect.
| int windowSum = 0; | ||
| for(int windowEnd = 0; windowEnd < vect.size(); windowEnd++) { | ||
| windowSum += vect[windowEnd]; | ||
| while(windowSum>=target){ |
There was a problem hiding this comment.
use proper space between the operands.
| vector<int>vect={3,4,7,1,9,2,12,1}; | ||
| int n=vect.size(); | ||
| int target=14; | ||
| int minlen=INT_MAX; |
There was a problem hiding this comment.
user camelCasing like minLength
|
Use class structure and not. Please look at the code of NoRepearSubstring. Also give a proper name to class & file like: |
aakashverma1124
force-pushed
the
main
branch
from
51692fe to
931628d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.