Skip to content

Build Soup.texts without @ (List.append) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tysg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build Soup.texts without @ (List.append) #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/soup.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,13 +443,16 @@ let rec leaf_text node =
| [child] -> leaf_text (forget_type child)
| _ -> None

let rec texts node =
match node.values with
| `Text s -> [s]
| `Element {children; _} ->
children |> List.map forget_type |> List.map texts |> List.fold_left (@) []
| `Document {roots; _} ->
roots |> List.map forget_type |> List.map texts |> List.fold_left (@) []
let texts node =
let rec collect acc node =
match node.values with
| `Text s -> s :: acc
| `Element {children; _} ->
List.fold_left (fun acc child -> collect acc (forget_type child)) acc children
| `Document {roots; _} ->
List.fold_left (fun acc root -> collect acc (forget_type root)) acc roots
in
List.rev (collect [] node)

let trimmed_texts node =
texts node
Expand Down
Loading