Multiple Region Codes #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Cleaned up and reuploaded the files |
Owner
|
I appreciate the PR! But I can't merge it as is; the tests haven't been updated to account for the modified behavior, and are consequently failing. There are also no new tests to verify that the newly added behavior functions correctly. I'm also curious what motivated the choice of semicolon-separated values on the |
Author
|
That's alright! I just came across your project while looking online, and
thought I'd add that functionality for myself, then realized I could upload
it. I'm new to GitHub and the system you were using to build/run the code.
I'm just a self taught java developer. I made the region member a separated
list of values because it was the easiest thing for me to write. I wasn't
sure how you were defining then accessing different elements, so I just
wrote something quick and dirty in my spare time. I appreciate the reply!
Sorry I didn't look into updating the tests.
Gabe
…On Mon, Jun 18, 2018, 2:34 PM Aaron Miller ***@***.***> wrote:
I appreciate the PR! But I can't merge it as is; the tests haven't been
updated to account for the modified behavior, and are consequently failing.
There are also no new tests to verify that the newly added behavior
functions correctly.
I'm also curious what motivated the choice of semicolon-separated values
on the region member. That seems like it'd be a headache to manage,
compared to having region be (or be able to be) an array of objects, with
each object representing a single region.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASy-ARS2CkMecUtkKwd_BOAUF61jumNKks5t9_KwgaJpZM4UhZF9>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality for multiple region codes. See server.js example for syntax. I left some debug stuff behind. I'll remove that and upload a new version