Add our repository in update script to PYTHONPATH#12
Merged
Conversation
empwilli
force-pushed
the
empwilli/fix_update_script
branch
from
794a108 to
1720285
Compare
mristin
approved these changes
Oct 30, 2025
| # . This means that the ``dev_scripts`` module will not be on the Python path, | ||
| # as newer versions of setuptools only put packages explicitly found by | ||
| # ``find_packages``. | ||
|
|
Contributor
There was a problem hiding this comment.
inline this in a function _add_our_repo_to_python_path, then call _add_our_repo_to_python_path in the global scope, so that this_path does not shadow this_path in main.
empwilli
force-pushed
the
empwilli/fix_update_script
branch
from
1720285 to
3b12575
Compare
mristin
approved these changes
Oct 30, 2025
We need to include the root of the repository in the dev. script for updating meta, codegen and testgen since newer Python versions (3.11 and 3.12, and newer) use more strict setuptools. Hence, the module ``dev_scripts/`` is not automatically included in PYTHONPATH.
empwilli
force-pushed
the
empwilli/fix_update_script
branch
from
3b12575 to
931f04a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to include the root of the repository in the dev. script for updating meta, codegen and testgen since newer Python versions (3.11 and 3.12, and newer) use more strict setuptools. Hence, the module
dev_scripts/is not automatically included in PYTHONPATH.