Extend rendering of formatted strings in patching#14
Merged
Conversation
The patching string needs to consider more cases of the original source code. Namely, we have to join strings together as micropython can not deal with them (``"test" "me"`` needs to be represented as ``"testme"``). So far, we only handled variables (``ast.Name``) and constants (``ast.Constant``), but recently we also have to handle a call and an attribute access (``type(value).__name__``). To that end, we extend the visitor for rendering formatted strings.
mristin
force-pushed
the
mristin/Extend-rendering-of-formatted-strs-in-patching
branch
from
9bb8b2b to
150d5a7
Compare
mristin
deleted the
mristin/Extend-rendering-of-formatted-strs-in-patching
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patching string needs to consider more cases of the original source code. Namely, we have to join strings together as micropython can not deal with them (
"test" "me"needs to be represented as"testme"). So far, we only handled variables (ast.Name) and constants (ast.Constant), but recently we also have to handle a call and an attribute access (type(value).__name__).To that end, we extend the visitor for rendering formatted strings.