fix: Centralize magic strings in Constants.cs#278
Closed
nbhansen wants to merge 1 commit intoaau-giraf:dev-mainfrom
Closed
fix: Centralize magic strings in Constants.cs#278nbhansen wants to merge 1 commit intoaau-giraf:dev-mainfrom
nbhansen wants to merge 1 commit intoaau-giraf:dev-mainfrom
Conversation
- Create VTA.API.Constants with DefaultBoardName, SessionArtefactCategory, ImageFilePrefix, and AssetDirectories constants - Replace hardcoded "Board1" in UsersController with Constants.DefaultBoardName - Replace hardcoded "Session-Artefact" in SavedArtefactsController - Replace hardcoded asset directory names in Program.cs - Replace hardcoded "image_" prefix in ImageUtilities - Update BoardsControllerTests to use constants for assertions All 98 tests passing. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
nbhansen
force-pushed
the
fix/backend-constants
branch
from
e37e641 to
2fd8af2
Compare
github-project-automation
bot
moved this from Backlog
to Done
in Visual Tangible Artefacts - 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Constants.csto centralize magic strings used across the backendConstants introduced:
Constants.DefaultBoardName("Board1")Constants.SessionArtefactCategory("Session-Artefact")Constants.ImageFilePrefix("image_")Constants.AssetDirectories.Artefacts,.Categories,.SoundsTest plan