fix: Return 201 Created from SignUp endpoint#279
Closed
nbhansen wants to merge 1 commit intoaau-giraf:dev-mainfrom
Closed
fix: Return 201 Created from SignUp endpoint#279nbhansen wants to merge 1 commit intoaau-giraf:dev-mainfrom
nbhansen wants to merge 1 commit intoaau-giraf:dev-mainfrom
Conversation
REST best practice: POST endpoints that create resources should return 201 Created with a Location header, not 200 OK. - Modified UsersController.SingUp to return CreatedAtAction pointing to GetUser endpoint - Refactored AutoSignIn helper to GenerateLoginResponse for clarity - Updated all test assertions to expect HttpStatusCode.Created - Removed TODO comments about this issue from tests and Utilities.cs All 98 tests passing. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
nbhansen
force-pushed
the
fix/signup-rest-violation
branch
from
85a61ed to
4a56d31
Compare
github-project-automation
bot
moved this from Backlog
to Done
in Visual Tangible Artefacts - 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locationheader pointing to the newly created user resourceTest plan
Locationheader is returned with correct URI